[ https://issues.apache.org/jira/browse/CASSANDRA-12937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713597#comment-17713597 ]
Stefan Miklosovic edited comment on CASSANDRA-12937 at 4/18/23 2:19 PM: ------------------------------------------------------------------------ https://github.com/apache/cassandra/pull/2281 1. flat map 2. ParameterizedClass - same stuff as everywhere 3. new format of values supported (as well as old) 4. some parameters / their names were deprecated in 3.0 so they can be removed in 5.0. {code} #sstable_compression: # - class_name: "org.apache.cassandra.io.compress.LZ4Compressor" # parameters: # - chunk_length: "32KiB" # min_compress_ratio: "0" {code} {code} #sstable_compression: # - class_name: "org.apache.cassandra.io.compress.LZ4Compressor" # parameters: # - chunk_length_in_kb: "32" # min_compress_ratio: "0" {code} All this works. I am not sure I covered all parameters but I expect that this might be done in a similar fashion. was (Author: smiklosovic): https://github.com/apache/cassandra/pull/2281 1. flat map 2. ParameterizedClass - same stuff as everywhere 3. new format of values supported (as well as old) 4. some parameters / their names were deprecated in 3.0 so they can be removed in 5.0. {code} #sstable_compression: # - class_name: "org.apache.cassandra.io.compress.LZ4Compressor" # parameters: # - chunk_length: "32KiB" # min_compress_ratio: "0" {code} {code} #sstable_compression: # - class_name: "org.apache.cassandra.io.compress.LZ4Compressor" # parameters: # - chunk_length_in_kb: "32" # min_compress_ratio: "0" {code} All this works. > Default setting (yaml) for SSTable compression > ---------------------------------------------- > > Key: CASSANDRA-12937 > URL: https://issues.apache.org/jira/browse/CASSANDRA-12937 > Project: Cassandra > Issue Type: Improvement > Components: Local/Config > Reporter: Michael Semb Wever > Assignee: Claude Warren > Priority: Low > Labels: AdventCalendar2021, lhf > Fix For: 5.x > > Time Spent: 3h > Remaining Estimate: 0h > > In many situations the choice of compression for sstables is more relevant to > the disks attached than to the schema and data. > This issue is to add to cassandra.yaml a default value for sstable > compression that new tables will inherit (instead of the defaults found in > {{CompressionParams.DEFAULT}}. > Examples where this can be relevant are filesystems that do on-the-fly > compression (btrfs, zfs) or specific disk configurations or even specific C* > versions (see CASSANDRA-10995 ). > +Additional information for newcomers+ > Some new fields need to be added to {{cassandra.yaml}} to allow specifying > the field required for defining the default compression parameters. In > {{DatabaseDescriptor}} a new {{CompressionParams}} field should be added for > the default compression. This field should be initialized in > {{DatabaseDescriptor.applySimpleConfig()}}. At the different places where > {{CompressionParams.DEFAULT}} was used the code should call > {{DatabaseDescriptor#getDefaultCompressionParams}} that should return some > copy of configured {{CompressionParams}}. > Some unit test using {{OverrideConfigurationLoader}} should be used to test > that the table schema use the new default when a new table is created (see > CreateTest for some example). -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org