[
https://issues.apache.org/jira/browse/CASSANDRA-18467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17720607#comment-17720607
]
Jakub Zytka commented on CASSANDRA-18467:
-----------------------------------------
IIUC the runs linked above verify that my changes do not cause regression with
{{{}ant{}}}.
I and [~e.dimitrova] did some manual checks with intellij too.
A potential problem is that people may use different workflows with intellij,
which we haven't tested. For reference, I'm using separate repos per jdk (i.e.
I'm hardly ever switching jdk for the same codebase), and [~e.dimitrova] did do
some switching. This resulted in adding {{.idea}} and {{iml}} project file
removal to {{generate-idea-files}} target. This is a change in behaviour,
although I think this is an improvement.
I considered adding the removal to {{realclean}} but opted otherwise, as I
believe project configuration is more general/abstract than actually cleaning.
During testing we fixed (manually) a problem [~e.dimitrova] was seeing: jdk
"11" in intellij, although advertised as 11.0.2, was pointing to installation
with java 17. I haven't spent time on figuring out why that was and assumed
this is an environmental issue (as jdk installations is a global configuration
in intellij, not tied to the project)
> Update generate-idea-files for J17
> ----------------------------------
>
> Key: CASSANDRA-18467
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18467
> Project: Cassandra
> Issue Type: Task
> Components: Build
> Reporter: Ekaterina Dimitrova
> Assignee: Jakub Zytka
> Priority: Low
> Fix For: 5.x
>
>
> There was a discussion in CASSANDRA-18258 how to update generate-idea-files.
> The final agreement was to create one target to cover both Java 11 and Java
> 17.
> It will be good to figure out CASSANDRA-18263 and reshuffle arguments and
> tasks based on what we decide to use as gc in testing for both Java 11 and
> Java 17.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
