[ 
https://issues.apache.org/jira/browse/CASSANDRA-18521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17723139#comment-17723139
 ] 

Andres de la Peña commented on CASSANDRA-18521:
-----------------------------------------------

The error in {{SelectiveIntersectionTest#tracingIsCorrectlyReported}} can also 
be hit on {{{}cep-7-sai{}}}:
 * 
[https://app.circleci.com/pipelines/github/adelapena/cassandra/2899/workflows/f7c11d0a-2e9f-4f1f-864a-76ee1d6a49d4/jobs/44809/tests]
 * 
[https://app.circleci.com/pipelines/github/adelapena/cassandra/2899/workflows/19456975-cb1c-4375-96ee-24c051f25f7d/jobs/44806/tests]

So it seems this patch doesn't introduce any new flakies.

> Unify CQLTester#waitForIndex and SAITester#waitForIndexQueryable
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-18521
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18521
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Feature/SAI
>            Reporter: Andres de la Peña
>            Assignee: Andres de la Peña
>            Priority: Normal
>             Fix For: NA
>
>
> It has been 
> [mentioned|https://github.com/maedhroz/cassandra/pull/11#discussion_r1190166765]
>  in CASSANDRA-18217 that {{CQLTester#waitForIndex}} and 
> {{SAITester#waitForIndexQueryable}} can be unified into a single method. 
> The same discussion mentions that it's easy to forget to call those methods 
> after calling {{CQLTester#createIndex}}. So that method can be renamed to 
> {{createIndexAsync}}, and we can create a new method that creates the index 
> and waits for it ({{createIndexSync}}, {{createIndexAndWaitForQueryable}}, or 
> something like that).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to