[ https://issues.apache.org/jira/browse/CASSANDRA-17194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17726617#comment-17726617 ]
Andres de la Peña commented on CASSANDRA-17194: ----------------------------------------------- {{compaction_large_partition_warning_threshold_mb}} has already been migrated by CASSANDRA-18500. The following patch deprecates {{compaction_tombstone_warning_threshold}} and adds a new equivalent guardrail: ||PR||CI|| |[trunk|https://github.com/apache/cassandra/pull/2369]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/2908/workflows/e85466e5-f29d-404c-bf6e-33cffa15fe53] [j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/2908/workflows/1ce7664c-13a3-4193-9ea9-c484e6b3395c]| CI looks good expect for a failure in {{FullQueryLoggerTest}} introduced by CASSANDRA-18550 and multiple failures in {{test_rolling_upgrade_with_internode_ssl}} reported by CASSANDRA-18499. [~bereng] could you please review, since this is very similar to CASSANDRA-18500? > Migrate thresholds for compaction to guardrails > ----------------------------------------------- > > Key: CASSANDRA-17194 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17194 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Guardrails > Reporter: Andres de la Peña > Assignee: Andres de la Peña > Priority: Normal > Time Spent: 10m > Remaining Estimate: 0h > > Migrate the existing thresholds for compaction: > {code:java} > compaction_large_partition_warning_threshold_mb: 100 > compaction_tombstone_warning_threshold: 100000 > {code} > To a new guardrail under the {{guardrails}} section, for example: > {code:java} > guardrails: > ... > compacted_partition_size_warn_threshold_mb: 100 > compacted_partition_tombstone_warn_threshold: 100000 > {code} > Or maybe: > {code:java} > guardrails: > ... > compacted_partition_size: > warn_threshold_mb: 100 > compacted_partition_tombstones: > warn_threshold: 100000 > {code} > Note that since these guardrails would be attached to a background process > there wouldn't be abort/fail thresholds because we don't want to stop > compaction. > At the moment these thresholds are enabled by default, while guardrails are > globally disabled by default, so we should consider whether we want to > globally enable guardrails, or change these thresholds to disabled by > default, or don't migrate the thresholds. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org