[ 
https://issues.apache.org/jira/browse/CASSANDRA-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093373#comment-13093373
 ] 

Jonathan Ellis commented on CASSANDRA-3051:
-------------------------------------------

- feels like we lose more than we gain by making writeHeader/write separate 
methods.  they aren't really self-contained so you have to keep the context 
they were called in, around mentally.  and if they were in-line, it would be 
obvious that you don't need to re-seek for each call to write().
- comments in write() don't really add much to what the code says, imo
- is flushing with each chunk necessary?  seems like that would harm performance


> On Disk Compression breaks SSL Encryption
> -----------------------------------------
>
>                 Key: CASSANDRA-3051
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3051
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.0
>         Environment: Trunk
>            Reporter: Benjamin Coverston
>            Assignee: Pavel Yaskevich
>             Fix For: 1.0
>
>         Attachments: CASSANDRA-3051.patch
>
>
> Encryption depends on FileStreamTask.write [1] protected member to be called 
> because the SSLFileStreamTask.write overrides this to write back to the 
> server.
> When enabled, compression circumvents the call and the client does not 
> communicate using an SSL socket back to the server.
> [1]
> protected long write(FileChannel fc, Pair<Long, Long> section, long length, 
> long bytesTransferred) throws IOException

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to