[ https://issues.apache.org/jira/browse/CASSANDRA-17194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andres de la Peña updated CASSANDRA-17194: ------------------------------------------ Description: Migrate the existing thresholds for compaction: {code:java} compaction_large_partition_warning_threshold_mb: 100 compaction_tombstone_warning_threshold: 100000 {code} To a new set of guardrails under the {{guardrails}} section, for example: {code:java} partition_size_warn_threshold: 50MiB partition_size_fail_threshold: 100MiB partition_tombstones_fail_threshold: 50000 partition_tombstones_fail_threshold: 100000 {code} Note that since these guardrails would be attached to a background process there wouldn't be abort/fail thresholds because we don't want to stop compaction. At the moment these thresholds are enabled by default, while guardrails are globally disabled by default, so we should consider whether we want to globally enable guardrails, or change these thresholds to disabled by default, or don't migrate the thresholds. was: Migrate the existing thresholds for compaction: {code:java} compaction_large_partition_warning_threshold_mb: 100 compaction_tombstone_warning_threshold: 100000 {code} To a new guardrail under the {{guardrails}} section, for example: {code:java} guardrails: ... compacted_partition_size_warn_threshold_mb: 100 compacted_partition_tombstone_warn_threshold: 100000 {code} Or maybe: {code:java} guardrails: ... compacted_partition_size: warn_threshold_mb: 100 compacted_partition_tombstones: warn_threshold: 100000 {code} Note that since these guardrails would be attached to a background process there wouldn't be abort/fail thresholds because we don't want to stop compaction. At the moment these thresholds are enabled by default, while guardrails are globally disabled by default, so we should consider whether we want to globally enable guardrails, or change these thresholds to disabled by default, or don't migrate the thresholds. > Migrate thresholds for compaction to guardrails > ----------------------------------------------- > > Key: CASSANDRA-17194 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17194 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Guardrails > Reporter: Andres de la Peña > Assignee: Andres de la Peña > Priority: Normal > Fix For: 5.x > > Time Spent: 1h 20m > Remaining Estimate: 0h > > Migrate the existing thresholds for compaction: > {code:java} > compaction_large_partition_warning_threshold_mb: 100 > compaction_tombstone_warning_threshold: 100000 > {code} > To a new set of guardrails under the {{guardrails}} section, for example: > {code:java} > partition_size_warn_threshold: 50MiB > partition_size_fail_threshold: 100MiB > partition_tombstones_fail_threshold: 50000 > partition_tombstones_fail_threshold: 100000 > {code} > Note that since these guardrails would be attached to a background process > there wouldn't be abort/fail thresholds because we don't want to stop > compaction. > At the moment these thresholds are enabled by default, while guardrails are > globally disabled by default, so we should consider whether we want to > globally enable guardrails, or change these thresholds to disabled by > default, or don't migrate the thresholds. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org