[
https://issues.apache.org/jira/browse/CASSANDRA-18190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17728070#comment-17728070
]
Ekaterina Dimitrova commented on CASSANDRA-18190:
-------------------------------------------------
Cross-posting from CASSANDRA-18239:
{quote}Some draft for using error-prone in the build
{quote}
That looks good, but unfortunately, to take advantage of the
[pattern|https://errorprone.info/bugpattern/MustBeClosedChecker] we are
interested in to replace eclipse-warnings, we need to start adding
@MustBeClosed for the methods that produce resources that must be closed.
I suspect this will regress quickly as we will be human-dependent; people will
start forgetting to use the annotation.
So to summarize:
* SpotBugs is not ready for newer JDK versions
* ErrorProne would involve manual work, and it will be human dependent
* sonar was mentioned not to be an option for direct replacement of eclipse
warnings
With that said, I should go back to CASSANDRA-18190 and review all the 100+ new
warnings we have with eclipse-warnings after upgrading it for newer JDK
versions...
> ECJ upgrade
> -----------
>
> Key: CASSANDRA-18190
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18190
> Project: Cassandra
> Issue Type: Task
> Components: Feature/UDF
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 5.x
>
>
> During testing it was identified that we will need to update ECJ for the Java
> UDF functions in order to bring Java 17 in.
> It seems the compiler artifacts are moved from
> [here|https://mvnrepository.com/artifact/org.eclipse.jdt.core.compiler/ecj ]
> to [here|https://mvnrepository.com/artifact/org.eclipse.jdt/ecj] and there is
> change of license from EPL1.0 to EPL2.0 too. But if I read correctly
> [here|https://www.apache.org/legal/resolved.html#weak-copyleft-licenses] that
> should not affect us
> Further testing and review of all changes between artifacts to be done.
> ECJ is used for the eclipse-warnings and Java UDFs
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
