[ https://issues.apache.org/jira/browse/CASSANDRA-18180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17728386#comment-17728386 ]
Ekaterina Dimitrova commented on CASSANDRA-18180: ------------------------------------------------- Thanks [~djatnieks] ! I talked in Slack with [~benedict] He looked into the patch and he also agreed with your approach. He has only one suggestion which is more about how to make it a bit more clear maybe and not a correctness issue or so: He thinks it might be nicer to have a wrapper class around the Ref. As that case matters only for testing purposes or if some DEBUG_ENABLED is active. (For reference - BufferPool.setAttachment) In this case we could set it to some object that contains the Ref and also implements DirectBuffer, so that we don’t leak these details into {{Ref}} which probably shouldn’t know of them and the extra indirection is only going to be incurred by hosts already paying a very high cost for managing the lifecycle I think both me and him are ok also with the current approach, so it will be up to the author whether to consider that suggestion > bulkLoaderSuccessfullyStreamsOverSsl fails with ClassCastException on JDK17 > --------------------------------------------------------------------------- > > Key: CASSANDRA-18180 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18180 > Project: Cassandra > Issue Type: Bug > Components: CI > Reporter: Ekaterina Dimitrova > Assignee: dan jatnieks > Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > While working on CASSANDRA-17992 we hit: > {code:java} > java.lang.ClassCastException: class > org.apache.cassandra.utils.memory.BufferPool$Chunk cannot be cast to class > sun.nio.ch.DirectBuffer (org.apache.cassandra.utils.memory.BufferPool$Chunk > is in unnamed module of loader 'app'; sun.nio.ch.DirectBuffer is in module > java.base of loader 'bootstrap')\n\tat > java.base/com.sun.crypto.provider.GaloisCounterMode$GCMEngine.overlapDetection(GaloisCounterMode.java:865)\n\tat > > java.base/com.sun.crypto.provider.GaloisCounterMode$GCMDecrypt.doFinal(GaloisCounterMode.java:1502)\n\tat > > java.base/com.sun.crypto.provider.GaloisCounterMode.engineDoFinal(GaloisCounterMode.java:447)\n\tat > > {code} > -The issue is exposed with JDK 17, trunk; if interested, ping- [~e.dimitrova] > -for current branch as there is no feature branch at the moment- we can > build and start from trunk with JDK17 already. Circle CI can be run for JDK17 > too. For more information how to do that - .circleci/readme.md > CC [~benedict] -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org