[
https://issues.apache.org/jira/browse/CASSANDRA-18285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17728521#comment-17728521
]
Ekaterina Dimitrova edited comment on CASSANDRA-18285 at 6/2/23 12:41 AM:
--------------------------------------------------------------------------
[~mck], in Jenkins Java upgrade tests on 4.0 and 4.1 are run only with 8. I
suspect this is because we do not have any forward testing. If I add a test
from 4.0 or 4.1 to 5.0, we will see in the test results also those being run
with JDK11, the same way we see all upgrade tests in trunk run with 11? Though
it seems in trunk, we should still see them run with 8 as it still needs to be
dropped
[here.|https://github.com/apache/cassandra-builds/commit/7e205252a001b9316efe98da329d26e3b62c1df9#diff-1f760d89dfb81ea05a11d862007a4e4e586b38aac7ae87f62c5b2e86571809c0R115]
What am I missing?
It seems we reject 11 pre-5.0 [here|
https://github.com/apache/cassandra-builds/commit/7e205252a001b9316efe98da329d26e3b62c1df9#diff-356361c2d7de0e1c4cdb47dd6d81a80567abd7d6f47b09925710c508f5d79b8dR47]
and I cannot recall why actually... This is probably because we do not have
forward Java upgrade tests, but they are not prohibited in the code? We have a
check if we upgrade to/*from* CURRENT
[here|https://github.com/apache/cassandra/commit/29ed31542bc7503c7c5695ce8012a555b4b3fb6f#diff-b04a7dc5d2948794698a86fc8df005db9cf8c94d9dbc900f7613b13b0b7d1649R198]
and
[here|https://github.com/apache/cassandra/commit/29ed31542bc7503c7c5695ce8012a555b4b3fb6f#diff-b04a7dc5d2948794698a86fc8df005db9cf8c94d9dbc900f7613b13b0b7d1649R217]
was (Author: e.dimitrova):
[~mck], in Jenkins Java upgrade tests on 4.0 and 4.1 are run only with 8. I
suspect this is because we do not have any forward testing. If I add a test
from 4.0 or 4.1 to 5.0, we will see in the test results also those being run
with JDK11, the same way we see all upgrade tests in trunk run with 11? Though
it seems in trunk, we should still see them run with 8 as it still needs to be
dropped
[here.|https://github.com/apache/cassandra-builds/commit/7e205252a001b9316efe98da329d26e3b62c1df9#diff-1f760d89dfb81ea05a11d862007a4e4e586b38aac7ae87f62c5b2e86571809c0R115]
What am I missing?
> Add JDK 11 upgrade tests for 4.0+ in CircleCI
> ---------------------------------------------
>
> Key: CASSANDRA-18285
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18285
> Project: Cassandra
> Issue Type: Task
> Components: CI
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.x
>
>
> Currently we test upgrades with Java 8, in preparation to drop it we need
> first to ensurer we test with 11. This has to be added not only in trunk,,
> but also 4.1
> I believe [~mck] has this ready to push in Jenkins at some point so this
> ticket should accommodate the addition of those upgrade tests in CircleCI for
> 4.1 and trunk.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
