[ https://issues.apache.org/jira/browse/CASSANDRA-17997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730049#comment-17730049 ]
Andres de la Peña commented on CASSANDRA-17997: ----------------------------------------------- Committed to 3.0 as [8d3c30dde4b615835073089594003ca40a730992|https://github.com/apache/cassandra/commit/8d3c30dde4b615835073089594003ca40a730992] and merged to [3.11|https://github.com/apache/cassandra/commit/3855c8a194d1d9ac904429407cb9586a6178e2f0], [4.0|https://github.com/apache/cassandra/commit/2393bb16f308d4d51335a97851646973aceb8066], [4.1|https://github.com/apache/cassandra/commit/2b2d9f9b725546c01017d688211931779565f39d] and [trunk|https://github.com/apache/cassandra/commit/e4f31b73c21b04966269c5ac2d3bd2562e5f6c63]. Thanks for the patch. > Improve git branch handling for CircleCI generate.sh > ---------------------------------------------------- > > Key: CASSANDRA-17997 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17997 > Project: Cassandra > Issue Type: Improvement > Components: CI > Reporter: Derek Chen-Becker > Assignee: Derek Chen-Becker > Priority: Normal > Fix For: 3.0.x, 4.0.x, 4.1.x, 5.x > > > The generate.sh script assumes a base git branch that is local and named > after the official repo branch (e.g. `cassandra-3.11`). This may not be a > local branch if the developer has recently cloned the repo and is creating a > work branch, and will lead to the git commands in generate.sh failing: > > ``` > fatal: ambiguous argument 'cassandra-3.11...HEAD': unknown revision or path > not in the working tree. > Use '--' to separate paths from revisions, like this: > 'git <command> [<revision>...] -- [<file>...]' > ``` > We should be able to make some sanity checks to better guide or warn the > developer if things aren't set up properly to check against git. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org