[ https://issues.apache.org/jira/browse/CASSANDRA-11745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730489#comment-17730489 ]
Benjamin Lerer commented on CASSANDRA-11745: -------------------------------------------- After quickly skimming the patch, it feels to me that the is a difference between the original goal of this ticket and of the patch. My understanding of [~slebresne] explanation was that the goal of this patch is about allowing the user to LIMIT by byte and _page_ by byte. What the patch does is to introduce a way to page by bytes instead of by rows but it seems to use that mechanism only for 2 scenarios which are internal paging for {{aggregation}}/{{group by}} queries and for rebuilding secondary indices. The values for those have to be configured within the config file. It is valuable but different from the original goal even if the functionality can probably be reused to build those other functionalities. So we should probably open another ticket with a clear description of the goal and moved the patch there to avoid confusing people. The patch being significant in terms of changes. The review will take some time in my side. > Add bytes limit to queries and paging > ------------------------------------- > > Key: CASSANDRA-11745 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11745 > Project: Cassandra > Issue Type: Improvement > Components: Legacy/Core > Reporter: Richard Low > Assignee: Jacek Lewandowski > Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > For some data models, values may be of very different sizes. When querying > data, limit by count doesn’t work well and leads to timeouts. It would be > much better to limit by size of the response, probably by stopping at the > first row that goes above the limit. This applies to paging too so you can > safely page through such data without timeout worries. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org