[
https://issues.apache.org/jira/browse/CASSANDRA-18572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17731552#comment-17731552
]
Stefan Miklosovic commented on CASSANDRA-18572:
-----------------------------------------------
I tried Doug's patch and it solves the issue I had but when I run the whole
test suite, the only test it fails on is ForceRepairTest.
I think that the problem is that "mocked" NodeTool/NodeProbe by means of
'InternalNodeProbe' is actually not closing MessagingService MBean in its
close() method. That means that even the second node in that test is shut down,
one clearly sees in the logs that the connection is still happening between the
first and third node with the second one we "stopped".
However, the way of re-using a proper NodeTool has the same behavior. We are
just closing jmx connector which should invalidate all mbean etc but it just do
not play together and I am not sure what the difference is.
The workaround is to enumerate features instead of calling .values() in config,
like this: .with(Feature.NETWORK, Feature.GOSSIP, Feature.NATIVE_PROTOCOL)) so
we are not using JMX which means it will fallback to the old way of doing
things.
It is worth to note that this is happening only in case one uses
Feature.value() in cluster configuration and one has to stop a node in the
middle of the test plus it does not happen every time. There is also
FailedBootstrapTest which uses same logic (Feature.values() and stopping a node
in the middle of the test) which is successful so this problem is not present
every time.
I would dedicate a separate ticket for this and I would just continue to work
on porting this ticket to older branches back to 3.11.
The branch for trunk is here https://github.com/apache/cassandra/pull/2394
> Instance.nodetoolResult should connect to JMX if there is such feature
> enabled in its config
> --------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-18572
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18572
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest/java
> Reporter: Stefan Miklosovic
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 5.x
>
> Attachments: fix-jmx-issue-on-shutdown.patch
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
