[ https://issues.apache.org/jira/browse/CASSANDRA-18585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17731686#comment-17731686 ]
Brandon Williams commented on CASSANDRA-18585: ---------------------------------------------- I think we should fix this everywhere it's present, I imagine this is easy to get into but very difficult to get out of. > Alter Type does not validate changes like Create Type does > ---------------------------------------------------------- > > Key: CASSANDRA-18585 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18585 > Project: Cassandra > Issue Type: Bug > Components: Cluster/Schema > Reporter: David Capwell > Priority: Normal > Fix For: 5.x > > > Create Type attempts to block undesired field types, but this validation is > not cared over to Alter Type Add Field; which allows you to add > unexpected/desired types > {code} > Assertions.assertThatThrownBy(() -> createType("CREATE TYPE %s (f > counter)")).hasRootCauseMessage("A user type cannot contain counters"); > String type = createType(KEYSPACE, "CREATE TYPE %s (a int)"); > schemaChange(String.format("ALTER TYPE %s.%s ADD f counter", KEYSPACE, type)); > UserType udt = > Keyspace.open(KEYSPACE).getMetadata().types.get(UTF8Type.instance.decompose(type)).get(); > logger.warn("UDT: {}", udt); > {code} > {code} > UDT: > org.apache.cassandra.db.marshal.UserType(cql_test_keyspace,747970655f3031,61:org.apache.cassandra.db.marshal.Int32Type,66:org.apache.cassandra.db.marshal.CounterColumnType) > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org