[
https://issues.apache.org/jira/browse/CASSANDRA-18305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735833#comment-17735833
]
Stefan Miklosovic edited comment on CASSANDRA-18305 at 6/21/23 5:49 PM:
------------------------------------------------------------------------
I have tested this branch (1) with this dtest branch (2) which was using this
ccm branch (3) and I run dtests against (1) here (4,5).
(2) needs to go to dtest as there is one test which is using a custom
wait_for_compaction method instead the one on node in ccm.
All changes were run against the current trunk (6) so I think we are good for
other branches too as nothing has changed but dtest / ccm which was tested in
the current trunk already.
I think the next steps are:
1) you merge (3) to ccm and update the tag
2) I merge (2)
3) then I do a full circle on (1) and we are done
(1) https://github.com/apache/cassandra/pull/2432/commits
(2) https://github.com/apache/cassandra-dtest/pull/222/files
(3) https://github.com/riptano/ccm/pull/752
(4) j8_dtest
https://app.circleci.com/pipelines/github/instaclustr/cassandra/2507/workflows/9b6867f2-a87e-4fd7-a833-fc66d5482a5b/jobs/59220
(5) j11_dtest
https://app.circleci.com/pipelines/github/instaclustr/cassandra/2507/workflows/9b6867f2-a87e-4fd7-a833-fc66d5482a5b/jobs/59221
(6)
https://app.circleci.com/pipelines/github/instaclustr/cassandra/2509/workflows/3c3c43cf-0626-4eeb-b76e-30711fcf7996/jobs/59336
was (Author: smiklosovic):
I have tested this branch (1) with this dtest branch (2) which was using this
ccm branch (3) and I run dtests against (1) here (4,5).
(2) needs to go to dtest as there is one test which is using a custom
wait_for_compaction method instead the one on node in ccm.
All changes were run against the current trunk (6) so I think we are good for
other branches too as nothing has changed but dtest / ccm which was tested in
the current trunk already.
(1) https://github.com/apache/cassandra/pull/2432/commits
(2) https://github.com/apache/cassandra-dtest/pull/222/files
(3) https://github.com/riptano/ccm/pull/752
(4) j8_dtest
https://app.circleci.com/pipelines/github/instaclustr/cassandra/2507/workflows/9b6867f2-a87e-4fd7-a833-fc66d5482a5b/jobs/59220
(5) j11_dtest
https://app.circleci.com/pipelines/github/instaclustr/cassandra/2507/workflows/9b6867f2-a87e-4fd7-a833-fc66d5482a5b/jobs/59221
(6)
https://app.circleci.com/pipelines/github/instaclustr/cassandra/2509/workflows/3c3c43cf-0626-4eeb-b76e-30711fcf7996/jobs/59336
> Enhance nodetool compactionstats with existing MBean metrics
> ------------------------------------------------------------
>
> Key: CASSANDRA-18305
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18305
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/nodetool
> Reporter: Brad Schoening
> Assignee: Manish Ghildiyal
> Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.x
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Nodetool compactionstats reports only on active compactions, if nothing is
> active, you see only:
> {quote}$nodetool compactionstats
> pending tasks: 0
> {quote}
> but in the MBean Compaction/TotalCompactionsCompleted there are recent
> statistic in events/second for:
> * Count
> * FifteenMinueRate
> * FiveMinueRate
> * MeanRate
> * OneMinuteRate
> 1) It would be useful to see in addition:
> {quote}pending tasks: 0
> compactions completed: 20
> 1 minute rate: 0/second
> 5 minute rate: 2.3/second
> 15 minute rate: 4.6/second
> {quote}
> 2) Since compaction_throughput_mb_per_sec is a throttling parameter in
> cassandra.yaml (default 64 MBps), it would be nice to show the actual
> compaction throughput and be able to observe if you're close to the limit.
> I.e.,
> {quote}compaction throughput 13.2 MBps / 16 MBps (82.5%)
> {quote}
> 3) for completness, compactionstats should list the number of concurrent
> compactors configured, perhaps simply add to existing 'pending tasks' line:
> {quote}4 concurrent compactors, 0 pending tasks
> {quote}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
