[ 
https://issues.apache.org/jira/browse/CASSANDRA-18180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736313#comment-17736313
 ] 

Ekaterina Dimitrova edited comment on CASSANDRA-18180 at 6/23/23 1:09 AM:
--------------------------------------------------------------------------

- Pushed new CI run with the latest changes - 
[https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=CASSANDRA-18180-trunk]
There are two tests that I haven't seen failing before. Tests in discussion:  
[test_move_backwards_and_cleanup|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2386/workflows/e604ddb5-85fb-4828-b6d5-aae56ba6e6a6/jobs/26557/tests#failed-test-0]
 - Python DTest

 * 
[testTruncationReleasesLogSpace-oa.jdk11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2386/workflows/ec4aaa50-acea-4c9d-bb20-5d139a6962ab/jobs/26575/tests#failed-test-0]
 - unit test

I managed to reproduce the test_move_backwards_and_cleanup on current trunk 
[here|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2390/workflows/719ea674-1f0f-4165-92ba-785469e1bb2f/jobs/27021/tests].
 I did not manage to reproduce the other one in 1000 runs but it seems it could 
be just something random. (file not available)
 - I ran the simulator tests with JDK17 again (locally until we get the JDK 17 
simulator tests job to CircleCI, CASSANDRA-18616)
 - I tested the check-test-names task. It works as expected.
 - The JDK change we address here affects only GCM, as per the JEP [~djatnieks] 
 pointed to. The wrapper looks ok to me and it is used only in 
debugging/testing.
 - I did not find any other places where we might be hitting this problem.
 - I also ran test_simple_bootstrap_with_ssl and sslnodetonode_test Python 
DTests with Netty version that uses by default JDK provider (netty 4.1.73, I 
also had at that branch netty-tcnative-boringssl-static - 2.0.51 but I do not 
think that matters here) and it was hitting this problem before. The tests pass 
with this patch.
 
Let's see if [~adelapena] will find something we are missing here, but I am 
personally +1 on the current work. (On squash, rebase and final CI ofc 
pre-commit)


was (Author: e.dimitrova):
- Pushed new CI run with the latest changes - 
[https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=CASSANDRA-18180-trunk]
There are two tests that I haven't seen failing before. Tests in discussion: * 
[test_move_backwards_and_cleanup|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2386/workflows/e604ddb5-85fb-4828-b6d5-aae56ba6e6a6/jobs/26557/tests#failed-test-0]
 - Python DTest

 * 
[testTruncationReleasesLogSpace-oa.jdk11|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2386/workflows/ec4aaa50-acea-4c9d-bb20-5d139a6962ab/jobs/26575/tests#failed-test-0]
 - unit test

I managed to reproduce the test_move_backwards_and_cleanup on current trunk 
[here|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2390/workflows/719ea674-1f0f-4165-92ba-785469e1bb2f/jobs/27021/tests].
 I did not manage to reproduce the other one in 1000 runs but it seems it could 
be just something random. (file not available)
 - I ran the simulator tests with JDK17 again (locally until we get the JDK 17 
simulator tests job to CircleCI, CASSANDRA-18616)
 - I tested the check-test-names task. It works as expected.
 - The JDK change we address here affects only GCM, as per the JEP [~djatnieks] 
 pointed to. The wrapper looks ok to me and it is used only in 
debugging/testing.
 - I did not find any other places where we might be hitting this problem.
 - I also ran test_simple_bootstrap_with_ssl and sslnodetonode_test Python 
DTests with Netty version that uses by default JDK provider (netty 4.1.73, I 
also had at that branch netty-tcnative-boringssl-static - 2.0.51 but I do not 
think that matters here) and it was hitting this problem before. The tests pass 
with this patch.
 
Let's see if [~adelapena] will find something we are missing here, but I am 
personally +1 on the current work. (On squash, rebase and final CI ofc 
pre-commit)

> bulkLoaderSuccessfullyStreamsOverSsl fails with ClassCastException on JDK17
> ---------------------------------------------------------------------------
>
>                 Key: CASSANDRA-18180
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18180
>             Project: Cassandra
>          Issue Type: Bug
>          Components: CI
>            Reporter: Ekaterina Dimitrova
>            Assignee: dan jatnieks
>            Priority: Normal
>             Fix For: 5.x
>
>         Attachments: cassandra-18180-directbufferref.diff
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> While working on CASSANDRA-17992 we hit: 
> {code:java}
> java.lang.ClassCastException: class 
> org.apache.cassandra.utils.memory.BufferPool$Chunk cannot be cast to class 
> sun.nio.ch.DirectBuffer (org.apache.cassandra.utils.memory.BufferPool$Chunk 
> is in unnamed module of loader 'app'; sun.nio.ch.DirectBuffer is in module 
> java.base of loader 'bootstrap')\n\tat 
> java.base/com.sun.crypto.provider.GaloisCounterMode$GCMEngine.overlapDetection(GaloisCounterMode.java:865)\n\tat
>  
> java.base/com.sun.crypto.provider.GaloisCounterMode$GCMDecrypt.doFinal(GaloisCounterMode.java:1502)\n\tat
>  
> java.base/com.sun.crypto.provider.GaloisCounterMode.engineDoFinal(GaloisCounterMode.java:447)\n\tat
>  
> {code}
> -The issue is exposed with JDK 17, trunk; if interested, ping- [~e.dimitrova] 
> -for current branch as there is no feature branch at the moment-  we can 
> build and start from trunk with JDK17 already. Circle CI can be run for JDK17 
> too. For more information how to do that - .circleci/readme.md
> CC [~benedict] 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to