[ https://issues.apache.org/jira/browse/CASSANDRA-18627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737322#comment-17737322 ]
Josh McKenzie commented on CASSANDRA-18627: ------------------------------------------- Hm. To anyone wandering past and curious, I'm not convinced this actually _fixes_ anything since the only call sites in theĀ {{PendingRepairManager}} actually don't pass in any additional sstables or bytes (just 0), so the compaction strategies don't have any estimated extra sstables or bytes to calculate anything from. I'll need to dig a bit into where those values make their way into this scope to then be passed on to compaction to determine where and why they're vestigial in this way. > Fix calculation of pending compactions in pending repair manager > ---------------------------------------------------------------- > > Key: CASSANDRA-18627 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18627 > Project: Cassandra > Issue Type: Bug > Components: Consistency/Repair, Local/Compaction > Reporter: Josh McKenzie > Assignee: Josh McKenzie > Priority: Normal > Fix For: 5.x > > > In CASSANDRA-17931, we failed to correctly take into account the > additionalSSTables and additionalBytes passed in in one of our calls to > {code}PendingRepairManager.getEstimatedRemainingTasks{code} -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org