[ 
https://issues.apache.org/jira/browse/CASSANDRA-17992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737735#comment-17737735
 ] 

Ekaterina Dimitrova commented on CASSANDRA-17992:
-------------------------------------------------

Thanks [~jlewandowski] !

So two things:
 - I noticed you pulled the patch from CASSANDRA-18180. Good call. But you are 
missing the bounty castle 
[patch|https://github.com/driftx/cassandra/commit/61c2863643f6ec85f73dbab4e1c3f37443a5c41c],
 which fixes the SSLFactory unit tests from this 
[issue|https://github.com/netty/netty/issues/10317] I mentioned earlier.

 - 
{quote} Otherwise, we may try to enable it explicitly, wdyt?{quote}

We can allow it in tests probably to cover people who might still need it for 
legacy reasons
{quote}We probably ought to do something similar to what we did in 
CASSANDRA-18540
{quote}
or more like CASSANDRA-16848, but fixed for Netty (I haven't looked into what 
that is, though)

> Upgrade Netty on 5.0
> --------------------
>
>                 Key: CASSANDRA-17992
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17992
>             Project: Cassandra
>          Issue Type: Task
>          Components: Dependencies
>            Reporter: Ekaterina Dimitrova
>            Assignee: Jacek Lewandowski
>            Priority: Low
>             Fix For: 5.x
>
>
> I haven't been able to identify from the Netty docs which was the lowest 
> version where JDK17 was added but we are about 40 versions behind in netty 4 
> so I suspect we better update. 
> -We need to consider there was an issue with class cast exceptions when 
> building with JDK17 with newer versions of netty (the newest available in 
> March 2022). For the record, we didn't see those when running CI on JDK8 and 
> JDK11. We also need to carefully revise the changes between the netty 
> versions. -->- CASSANDRA-18180
> Upgrading will cover also a fix in netty that was discussed in 
> [this|https://the-asf.slack.com/archives/CK23JSY2K/p1665567660202989] ASF 
> Slack thread. 
> CC [~benedict] , [~aleksey] 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to