[ 
https://issues.apache.org/jira/browse/CASSANDRA-18618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17738243#comment-17738243
 ] 

Ekaterina Dimitrova commented on CASSANDRA-18618:
-------------------------------------------------

I can confirm that also I see that with the change of not including the 
checkstyle on test runs, we solve the JDK11 checkstyle issue from 
CASSANDRA-18423.

The tests that were failing pass successfully here - 
[https://ci-cassandra.apache.org/view/patches/job/Cassandra-devbranch/2519/testReport/org.apache.cassandra.io.sstable.indexsummary/IndexSummaryTest/]

This also fixes the issue that the jvm crash was preventing additional tests 
from not running at all.

I can see that [~jlewandowski] 's patch is actually running 
[16,380|https://ci-cassandra.apache.org/job/Cassandra-devbranch-test/1894/testReport/]
 tests while in trunk we have on the last run 
[15,982|https://ci-cassandra.apache.org/job/Cassandra-trunk-test/lastCompletedBuild/testReport/].
 [~mck], any idea why we might be running more tests in Jenkins-dev compared to 
post-commit? It seems both run JDK8+11 (no JDK17 in any of them) 

The number of skipped tests is about the same. 

> Update tasks configuration to run checks locally when requested
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-18618
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18618
>             Project: Cassandra
>          Issue Type: Task
>          Components: Build
>            Reporter: Jacek Lewandowski
>            Assignee: Jacek Lewandowski
>            Priority: Normal
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Currently CheckStyle and RAT are run with almost every single Ant target, 
> which is annoying as when developing locally. The targets should be clear - 
> "test" - runs the tests, "jar" - builds the project and creates jars, and 
> then we should have a task "check" which runs all the static analysis, that 
> is CheckStyle, RAT and Eclipse-Warnings (or whatever we decide to replace 
> Eclipse-Warnings with).
> Such goal should be include in "artifacts" and we should run it instead of 
> "eclipse-warnings" on CircleCI. This way building, static analysis and 
> testings are clearly separated.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to