[ 
https://issues.apache.org/jira/browse/CASSANDRA-18438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17738942#comment-17738942
 ] 

Stefan Miklosovic edited comment on CASSANDRA-18438 at 6/30/23 8:15 AM:
------------------------------------------------------------------------

_can we template this similar in the future_

The existing snitches have to stay as they are because of backward 
compatibility. They still need to be referenced in cassandra.yaml so they have 
to exist.

However, for all other "custom cloud snitches" which might eventually come in 
the future, we may have some "DefaultCloudMetadataServiceSnitch" which would 
have one URL of metadata service as a parameter and it would parse the query 
result in very opinionated way. If somebody wants anything more custom, they 
would need to implement it.


was (Author: smiklosovic):
_can we template this similar in the future_

The existing snitches have to stay as they are because of backward 
compatibility. They still need to be referenced in cassandra.yaml so they have 
to exist.

However, for all other "custom cloud snitches" there might eventually come in 
the future, we may have some "DefaultCloudMetadataServiceSnitch" which would 
have one URL of metadata service as a parameter and it would parse the query 
result in very opinionated way. If somebody wants anything more custom, they 
would need to implement it.

> Refactor the code for public cloud platform snitch to be configurable
> ---------------------------------------------------------------------
>
>                 Key: CASSANDRA-18438
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18438
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Local/Other
>            Reporter: Maxwell Guo
>            Assignee: Maxwell Guo
>            Priority: Normal
>             Fix For: 5.x
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Nowadays we have got about four public cloud platform snitchs : EC2 snitch 
> for aws, google cloud snitch for google cloud, alibaba cloud snitch for 
> alibaba cloud and multi region snitch for ec2. And the common place for the 
> first three is that we just need to query the zone center to get the ec2 / 
> ecs id , so I think we can refactor the code , and  if some new public cloud 
> platform want to add one more snitch for himself, there is no need to pull a 
> pr for him and  configure some options in yaml is enough .
> Besides it would be even better that we may reuse the multic region snitch 
> for ec2 for other public cloud platform.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to