[ 
https://issues.apache.org/jira/browse/CASSANDRA-18582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740855#comment-17740855
 ] 

dan jatnieks commented on CASSANDRA-18582:
------------------------------------------

[~e.dimitrova] Thanks for starting the CI runs and for letting me know about 
the tests failing in {{SSTableLoaderEncryptionOptionsTest}} ... that's actually 
one of the tests I was working on in another ticket, so I should have noticed 
:( 

I fixed the test, rebased, and pushed updates to each branch. 

I ended up squashing the changes though - so for clarity, I'll just describe 
the problem with the test here. 

The {{EncryptionOptions.cipherSuitesArray}} method was returning an empty array 
when {{cipher_suites}} is {{null}}. However, something downstream of 
{{RemoteEndpointAwareJdkSSLOptions}} doesn't like an empty array - I'm not sure 
what, but just returning {{null}} solves it. 

I also added an explicit {{--ssl-ciphers}} option to 
{{SSTableLoaderEncryptionOptionsTest.bulkLoaderSuccessfullyStreamsOverSsl}} to 
cover the case where the cipher suite option is being set. 

And, I left 
{{bulkLoaderSuccessfullyStreamsOverSslWithDeprecatedSslStoragePort}} without 
specifying a {{cipher-suite}} option to cover the default (null) case.

Thanks again for the help!



> BulkLoader withCipherSuites option is ignored
> ---------------------------------------------
>
>                 Key: CASSANDRA-18582
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18582
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tool/bulk load
>            Reporter: dan jatnieks
>            Assignee: dan jatnieks
>            Priority: Normal
>             Fix For: 4.0.x, 4.1.x, 5.x
>
>
> The {{withCipherSuites}} option of {{BulkLoader}} is being ignored. It seems 
> that since CASSANDRA-16362 the {{BulkLoader.buildSSLOptions}} method no 
> longer applies the cipher suite options provided by 
> {{clientEncryptionOptions}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to