[ https://issues.apache.org/jira/browse/CASSANDRA-18617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17742914#comment-17742914 ]
Brandon Williams commented on CASSANDRA-18617: ---------------------------------------------- This looks good to me, and keeping the JMX api stable is the right call. +1 > Disable the deprecated keyspace/table thresholds and convert them to > Guardrails > ------------------------------------------------------------------------------- > > Key: CASSANDRA-18617 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18617 > Project: Cassandra > Issue Type: Improvement > Components: Feature/Guardrails > Reporter: dan jatnieks > Assignee: dan jatnieks > Priority: Normal > Fix For: 5.x > > Time Spent: 1h 50m > Remaining Estimate: 0h > > The non-guardrail thresholds 'keyspace_count_warn_threshold' and > 'table_count_warn_threshold' configuration settings were first added with > CASSANDRA-16309 in 4.0-beta4 and have subsequently been deprecated since > 4.1-alpha in CASSANDRA-17195 when they were replaced/migrated to guardrails > as part of CEP-3 (Guardrails). > These thresholds should now be removed from cassandra.yaml, while still > allowed in existing yaml files. > The old thresholds will be disabled by removing their default values from > Config.java, and any existing values for these thresholds will be converted > to the new guardrails using the '@Replaces' tag on the corresponding > guardrail values. > Since the old thresholds considered the number of system keyspace/tables in > their values, the '@Replaces' conversion will subtract the current number of > system tables from the old value and log a descriptive message. > See dev list discussion: > https://lists.apache.org/thread/0zjg08hrd6xv7lhvo96frz456b2rvr8b -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org