[ https://issues.apache.org/jira/browse/CASSANDRA-18313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745570#comment-17745570 ]
Maxim Muzafarov commented on CASSANDRA-18313: --------------------------------------------- I have browsed through the changes and from my humble JMX backward compatibility knowledge of the product everything looks correct (minor: {{"org.apache.cassandra.metrics:type=DroppedMessage.*"}} is mentioned twice, did you add it explicitly?). This is unrelated to the change itself, but I came across the following {{LegacyFlag}} class, which is a good candidate for the {{cassandra-post-4x-cleanup}} without having a ticket for it yet, right? It's not easy as the current one, but at least we can create an issue to highlight this piece of code. https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/net/LegacyFlag.java#L36 > Remove legacy 3.x buffer pool metrics > ------------------------------------- > > Key: CASSANDRA-18313 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18313 > Project: Cassandra > Issue Type: Task > Components: Observability/JMX > Reporter: Michael Semb Wever > Assignee: Michael Semb Wever > Priority: Normal > Fix For: 5.x > > > Remove BufferPoolMetrics.register3xAlias() > Patch: > https://github.com/apache/cassandra/compare/trunk...thelastpickle:cassandra:mck/18313/trunk -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org