[
https://issues.apache.org/jira/browse/CASSANDRA-18708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17749950#comment-17749950
]
Ekaterina Dimitrova edited comment on CASSANDRA-18708 at 8/1/23 9:29 PM:
-------------------------------------------------------------------------
This can fail not only this way, as seen here -
[https://ci-cassandra.apache.org/job/Cassandra-trunk/1643/testReport/junit/org.apache.cassandra.tools/StandaloneSplitterWithCQLTesterTest/testNoSnapshotOption__jdk17/]:
h3.
{code:java}
Error Message
java.lang.reflect.InaccessibleObjectException: Unable to make field private
final java.lang.Object
java.nio.channels.spi.AbstractInterruptibleChannel.closeLock accessible: module
java.base does not "opens java.nio.channels.spi" to unnamed module @57536d79 at
java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:354)
at
java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297)
at java.base/java.lang.reflect.Field.checkCanSetAccessible(Field.java:178) at
java.base/java.lang.reflect.Field.setAccessible(Field.java:172) at
org.apache.cassandra.utils.concurrent.Ref.getFields(Ref.java:656) at
org.apache.cassandra.utils.concurrent.Ref.getFields(Ref.java:659) at
org.apache.cassandra.utils.concurrent.Ref.getFields(Ref.java:659) at
org.apache.cassandra.utils.concurrent.Ref$Visitor.traverse(Ref.java:613) at
org.apache.cassandra.utils.concurrent.Ref$Visitor.run(Ref.java:568) at
org.apache.cassandra.concurrent.ExecutionFailure$1.run(ExecutionFailure.java:133)
at
java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
at java.base/java.util.concurrent.FutureTask.runAndReset(FutureTask.java:305)
at
java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305)
at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at
io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
at java.base/java.lang.Thread.run(Thread.java:833)
Stacktrace
junit.framework.AssertionFailedError:
java.lang.reflect.InaccessibleObjectException: Unable to make field private
final java.lang.Object
java.nio.channels.spi.AbstractInterruptibleChannel.closeLock accessible: module
java.base does not "opens java.nio.channels.spi" to unnamed module @57536d79 at
java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:354)
at
java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297)
at java.base/java.lang.reflect.Field.checkCanSetAccessible(Field.java:178) at
java.base/java.lang.reflect.Field.setAccessible(Field.java:172) at
org.apache.cassandra.utils.concurrent.Ref.getFields(Ref.java:656) at
org.apache.cassandra.utils.concurrent.Ref.getFields(Ref.java:659) at
org.apache.cassandra.utils.concurrent.Ref.getFields(Ref.java:659) at
org.apache.cassandra.utils.concurrent.Ref$Visitor.traverse(Ref.java:613) at
org.apache.cassandra.utils.concurrent.Ref$Visitor.run(Ref.java:568) at
org.apache.cassandra.concurrent.ExecutionFailure$1.run(ExecutionFailure.java:133)
at
java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
at java.base/java.util.concurrent.FutureTask.runAndReset(FutureTask.java:305)
at
java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305)
at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at
io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
at java.base/java.lang.Thread.run(Thread.java:833) at
org.apache.cassandra.tools.StandaloneSplitterWithCQLTesterTest.testNoSnapshotOption(StandaloneSplitterWithCQLTesterTest.java:109)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method) at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
{code}
I couldn't reproduce it locally in hundreds of runs. The solution is not adding
more add-opens as we do not also access concrete fields...similar to the jamm
traversals problems.
I have a potential patch, but I need to check a few more things. I also suspect
another patch/ticket might be fixing some of those accesses issues, too. More
to come
was (Author: e.dimitrova):
This can fail only this way, as seen here -
[https://ci-cassandra.apache.org/job/Cassandra-trunk/1643/testReport/junit/org.apache.cassandra.tools/StandaloneSplitterWithCQLTesterTest/testNoSnapshotOption__jdk17/]:
h3.
{code:java}
Error Message
java.lang.reflect.InaccessibleObjectException: Unable to make field private
final java.lang.Object
java.nio.channels.spi.AbstractInterruptibleChannel.closeLock accessible: module
java.base does not "opens java.nio.channels.spi" to unnamed module @57536d79 at
java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:354)
at
java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297)
at java.base/java.lang.reflect.Field.checkCanSetAccessible(Field.java:178) at
java.base/java.lang.reflect.Field.setAccessible(Field.java:172) at
org.apache.cassandra.utils.concurrent.Ref.getFields(Ref.java:656) at
org.apache.cassandra.utils.concurrent.Ref.getFields(Ref.java:659) at
org.apache.cassandra.utils.concurrent.Ref.getFields(Ref.java:659) at
org.apache.cassandra.utils.concurrent.Ref$Visitor.traverse(Ref.java:613) at
org.apache.cassandra.utils.concurrent.Ref$Visitor.run(Ref.java:568) at
org.apache.cassandra.concurrent.ExecutionFailure$1.run(ExecutionFailure.java:133)
at
java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
at java.base/java.util.concurrent.FutureTask.runAndReset(FutureTask.java:305)
at
java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305)
at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at
io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
at java.base/java.lang.Thread.run(Thread.java:833)
Stacktrace
junit.framework.AssertionFailedError:
java.lang.reflect.InaccessibleObjectException: Unable to make field private
final java.lang.Object
java.nio.channels.spi.AbstractInterruptibleChannel.closeLock accessible: module
java.base does not "opens java.nio.channels.spi" to unnamed module @57536d79 at
java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:354)
at
java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297)
at java.base/java.lang.reflect.Field.checkCanSetAccessible(Field.java:178) at
java.base/java.lang.reflect.Field.setAccessible(Field.java:172) at
org.apache.cassandra.utils.concurrent.Ref.getFields(Ref.java:656) at
org.apache.cassandra.utils.concurrent.Ref.getFields(Ref.java:659) at
org.apache.cassandra.utils.concurrent.Ref.getFields(Ref.java:659) at
org.apache.cassandra.utils.concurrent.Ref$Visitor.traverse(Ref.java:613) at
org.apache.cassandra.utils.concurrent.Ref$Visitor.run(Ref.java:568) at
org.apache.cassandra.concurrent.ExecutionFailure$1.run(ExecutionFailure.java:133)
at
java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
at java.base/java.util.concurrent.FutureTask.runAndReset(FutureTask.java:305)
at
java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305)
at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at
io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
at java.base/java.lang.Thread.run(Thread.java:833) at
org.apache.cassandra.tools.StandaloneSplitterWithCQLTesterTest.testNoSnapshotOption(StandaloneSplitterWithCQLTesterTest.java:109)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method) at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
{code}
I couldn't reproduce it locally in hundreds of runs. The solution is not adding
more add-opens as we do not also access concrete fields...similar to the jamm
traversals problems.
I have a potential patch, but I need to check a few more things. I also suspect
another patch/ticket might be fixing some of those accesses issues, too. More
to come
> Test failure:
> org.apache.cassandra.tools.StandaloneSplitterWithCQLTesterTest.testNoSnapshotOption-.jdk17
> --------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-18708
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18708
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 5.x
>
>
> Seen here:
> [https://ci-cassandra.apache.org/job/Cassandra-trunk/1650/testReport/junit/org.apache.cassandra.tools/StandaloneSplitterWithCQLTesterTest/testNoSnapshotOption__jdk17/]
> h3.
> {code:java}
> Error Message
> java.lang.reflect.InaccessibleObjectException: Unable to make field private
> final sun.nio.fs.UnixFileSystem sun.nio.fs.UnixPath.fs accessible: module
> java.base does not "opens sun.nio.fs" to unnamed module @1f28c152 at
> java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:354)
> at
> java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297)
> at java.base/java.lang.reflect.Field.checkCanSetAccessible(Field.java:178)
> at java.base/java.lang.reflect.Field.setAccessible(Field.java:172) at
> org.apache.cassandra.utils.concurrent.Ref.getFields(Ref.java:656) at
> org.apache.cassandra.utils.concurrent.Ref$Visitor.traverse(Ref.java:613) at
> org.apache.cassandra.utils.concurrent.Ref$Visitor.run(Ref.java:568) at
> org.apache.cassandra.concurrent.ExecutionFailure$1.run(ExecutionFailure.java:133)
> at
> java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
> at
> java.base/java.util.concurrent.FutureTask.runAndReset(FutureTask.java:305) at
> java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
> at
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
> at
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
> at java.base/java.lang.Thread.run(Thread.java:833)
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
