[ 
https://issues.apache.org/jira/browse/CASSANDRA-18743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755249#comment-17755249
 ] 

Maxim Muzafarov edited comment on CASSANDRA-18743 at 8/16/23 8:39 PM:
----------------------------------------------------------------------

I haven't found usages of the {{org.apache.commons.codec}} package, so I think 
we can easily remove this dependency, the code also compiles without it. 
However, I'm not sure if such a change is related to the patch itself as there 
is no requirement for this package from the metrics-reporter-config side. 

Should we file an separate issue for that?



was (Author: mmuzaf):
I haven't found usages of the {{org.apache.commons.codec}} package, so I think 
we can easily remove this dependency, the code also compiles without it. 
However, I'm not sure if such a change is related to the patch itself as there 
is no requirement for this package from the metrics-reporter-config side. 



> Remove dependency on archived project metrics-reporter-config
> -------------------------------------------------------------
>
>                 Key: CASSANDRA-18743
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18743
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Local/Config
>            Reporter: Abe Ratnofsky
>            Assignee: Maxim Muzafarov
>            Priority: Normal
>             Fix For: 5.0, 5.x
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> metrics-reporter-config has been archived for over 3 years, and has received 
> no updates in nearly 6 years:
> https://github.com/addthis/metrics-reporter-config
> metrics-reporter-config processes YAML unsafely: 
> https://github.com/addthis/metrics-reporter-config/blob/master/reporter-config-base/src/main/java/com/addthis/metrics/reporter/config/AbstractReporterConfig.java#L39C34-L39C45
> This is related to CASSANDRA-18614, which is focused on migrating to safe 
> YAML processing for the main configuration files.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to