[ https://issues.apache.org/jira/browse/CASSANDRA-18772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755541#comment-17755541 ]
Maxim Muzafarov commented on CASSANDRA-18772: --------------------------------------------- OK, I've found an easy way to find all the unused dependencies, but this list should be carefully filtered, as some of the "unused dependencies" may actually be used at runtime. I doubt we can add running of this command to the ant build as the maven is used. h3. The command Tested on the latest trunk (\{{commons-codec}} is there). {code:java} mvn -f ./build/apache-cassandra-5.0-SNAPSHOT.pom org.apache.maven.plugins:maven-dependency-plugin:3.2.0:analyze -Dverbose=true -DignoreNonCompile {code} h3. The result {code:java} [INFO] --- dependency:3.2.0:analyze (default-cli) @ cassandra-all --- [WARNING] Unused declared dependencies found: [WARNING] com.github.jnr:jffi:jar:native:1.3.11:compile [WARNING] net.openhft:chronicle-threads:jar:2.23.25:compile [WARNING] org.psjava:psjava:jar:0.1.19:compile [WARNING] ch.qos.logback:logback-core:jar:1.2.9:compile [WARNING] io.netty:netty-transport-native-epoll:jar:4.1.94.Final:compile [WARNING] org.lz4:lz4-java:jar:1.8.0:compile [WARNING] org.apache.commons:commons-lang3:jar:3.11:compile [WARNING] com.fasterxml.jackson.core:jackson-annotations:jar:2.13.2:compile [WARNING] net.openhft:chronicle-bytes:jar:2.23.33:compile [WARNING] ch.obermuhlner:big-math:jar:2.3.0:compile [WARNING] io.airlift:airline:jar:0.8:compile [WARNING] io.dropwizard.metrics:metrics-logback:jar:3.1.5:compile [WARNING] io.dropwizard.metrics:metrics-core:jar:3.1.5:compile [WARNING] org.gridkit.jvmtool:sjk-core:jar:0.14:compile [WARNING] com.github.seancfoley:ipaddress:jar:5.3.3:compile [WARNING] com.google.j2objc:j2objc-annotations:jar:1.3:compile [WARNING] com.fasterxml.jackson.core:jackson-databind:jar:2.13.2.2:compile [WARNING] net.java.dev.jna:jna:jar:5.13.0:compile [WARNING] org.gridkit.lab:jvm-attach-api:jar:1.5:compile [WARNING] org.gridkit.jvmtool:sjk-json:jar:0.14:compile [WARNING] org.agrona:agrona:jar:1.17.1:compile [WARNING] org.slf4j:jcl-over-slf4j:jar:1.7.25:compile [WARNING] com.fasterxml.jackson.datatype:jackson-datatype-jsr310:jar:2.13.2:compile [WARNING] com.github.jbellis:jamm:jar:0.4.0:compile [WARNING] net.openhft:posix:jar:2.24ea4:compile [WARNING] net.openhft:chronicle-queue:jar:5.23.37:compile [WARNING] commons-codec:commons-codec:jar:1.9:compile [WARNING] com.boundary:high-scale-lib:jar:1.0.6:compile [WARNING] org.caffinitas.ohc:ohc-core-j8:jar:0.5.1:compile [WARNING] com.addthis.metrics:reporter-config3:jar:3.0.3:compile [WARNING] com.datastax.cassandra:cassandra-driver-core:jar:shaded:3.11.0:compile [WARNING] com.github.luben:zstd-jni:jar:1.5.5-1:compile [WARNING] com.carrotsearch:hppc:jar:0.8.1:compile [WARNING] org.xerial.snappy:snappy-java:jar:1.1.10.1:compile [WARNING] org.bouncycastle:bcpkix-jdk15on:jar:1.70:compile [WARNING] com.google.code.findbugs:jsr305:jar:2.0.2:compile [WARNING] com.clearspring.analytics:stream:jar:2.5.2:compile [WARNING] org.mindrot:jbcrypt:jar:0.4:compile [WARNING] io.netty:netty-transport-native-epoll:jar:linux-x86_64:4.1.94.Final:compile [WARNING] ch.qos.logback:logback-classic:jar:1.2.9:compile [WARNING] com.google.guava:guava:jar:32.0.1-jre:compile [WARNING] org.apache.commons:commons-math3:jar:3.2:compile [WARNING] org.yaml:snakeyaml:jar:1.26:compile [WARNING] org.apache.lucene:lucene-core:jar:9.7.0:compile [WARNING] net.openhft:affinity:jar:3.23.3:compile [WARNING] org.eclipse.jdt:ecj:jar:3.33.0:compile [WARNING] org.slf4j:log4j-over-slf4j:jar:1.7.25:compile [WARNING] org.caffinitas.ohc:ohc-core:jar:0.5.1:compile [WARNING] org.gridkit.jvmtool:sjk-cli:jar:0.14:compile [WARNING] org.apache.lucene:lucene-analysis-common:jar:9.7.0:compile [WARNING] com.github.jnr:jnr-constants:jar:0.10.4:compile [WARNING] org.hdrhistogram:HdrHistogram:jar:2.1.9:compile [WARNING] net.openhft:chronicle-core:jar:2.23.36:compile [WARNING] com.github.ben-manes.caffeine:caffeine:jar:2.9.2:compile [WARNING] org.antlr:ST4:jar:4.0.8:compile [WARNING] org.gridkit.jvmtool:mxdump:jar:0.14:compile [WARNING] io.netty:netty-tcnative-boringssl-static:jar:2.0.61.Final:compile [WARNING] org.antlr:antlr-runtime:jar:3.5.2:compile [WARNING] com.beust:jcommander:jar:1.30:compile [WARNING] com.fasterxml.jackson.core:jackson-core:jar:2.13.2:compile [WARNING] javax.inject:javax.inject:jar:1:compile [WARNING] io.dropwizard.metrics:metrics-jvm:jar:3.1.5:compile [WARNING] commons-cli:commons-cli:jar:1.5.0:compile [WARNING] com.github.jnr:jnr-ffi:jar:2.2.13:compile [WARNING] org.slf4j:slf4j-api:jar:1.7.25:compile [WARNING] org.fusesource:sigar:jar:1.6.4:compile [WARNING] org.jctools:jctools-core:jar:3.1.0:compile [WARNING] net.openhft:chronicle-wire:jar:2.23.39:compile [WARNING] net.java.dev.jna:jna-platform:jar:5.13.0:compile [WARNING] com.github.jnr:jffi:jar:1.3.11:compile [WARNING] com.googlecode.concurrent-trees:concurrent-trees:jar:2.4.0:compile [WARNING] io.netty:netty-all:jar:4.1.96.Final:compile [WARNING] org.ow2.asm:asm:jar:9.4:compile [WARNING] org.gridkit.jvmtool:sjk-stacktrace:jar:0.14:compile [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 1.648 s [INFO] Finished at: 2023-08-17T14:51:12+02:00 [INFO] ------------------------------------------------------------------------ {code} > Remove dependency on commons-codec > ---------------------------------- > > Key: CASSANDRA-18772 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18772 > Project: Cassandra > Issue Type: Bug > Components: Dependencies > Reporter: Ekaterina Dimitrova > Assignee: Ekaterina Dimitrova > Priority: Normal > Fix For: 5.0.x, 5.x > > > The dependency doesn't seem to have any direct usage in our codebase. > The only reference to how it might be used was found in CASSANDRA-12790. > Considering we also deprecate in 5.0 and remove metrics-reporter-config as > part of CASSANDRA-18743, I do not see a reason not to remove this one too. > We should probably take the same approach as CASSANDRA-18743 - deprecate in > 5.0 and remove in 5.1. ML thread is to be opened too. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org