[ https://issues.apache.org/jira/browse/CASSANDRA-18717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757438#comment-17757438 ]
Stefan Miklosovic edited comment on CASSANDRA-18717 at 8/22/23 1:05 PM: ------------------------------------------------------------------------ We can just wait for ceps to lend and then we push this with failing the CI on broken javadocs, no? If we merge this now, then cep guys have to probably deal with some conflicts on rebase and / or they need to fix their stuff (which they presumably wont as we dont fail it). So then we need to return to that again. That is 3 commits against just 2. BTW I think that CEP work will be split into multiple commits as well so if they have like 20 commits to deliver and they need to rebase all of that and they need to resolve all the conflicts as they do so ... brrr, terrible. As CEP branches are already on GitHub, would somebody mind to rebase them locally against the current trunk and then this branch against trunk to see how complicated that would be? was (Author: smiklosovic): We can just wait for ceps to lend and then we push this with failing the CI on broken javadocs, no? If we merge this now, then cep guys have to probably deal with some conflicts on rebase and / or they need to fix their stuff (which they presumably wont as we dont fail it). So then we need to return to that again. That is 3 commits against just 2. BTW I think that CEP work will be split into multiple commits as well so if they have like 20 commits to deliver and they need to rebase all of that and they need to resolve all the conflicts as they do so ... brrr, terrible. > Fix errors or remove ant javadoc task > ------------------------------------- > > Key: CASSANDRA-18717 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18717 > Project: Cassandra > Issue Type: Bug > Components: Documentation/Javadoc > Reporter: Ekaterina Dimitrova > Assignee: Maxim Muzafarov > Priority: Normal > Fix For: 5.0.x, 5.x > > Time Spent: 50m > Remaining Estimate: 0h > > As discussed on CASSANDRA-17687, the javadoc task completes successfully, but > there are errors that deserve to be fixed if we keep the task around. > If we do not plan to use it, we should remove it and reduce the clutter. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org