[ https://issues.apache.org/jira/browse/CASSANDRA-18750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758150#comment-17758150 ]
Stefan Miklosovic edited comment on CASSANDRA-18750 at 8/23/23 4:38 PM: ------------------------------------------------------------------------ I am sorry I am stepping in to this ticket relatively late but I have this question ... Do not we want to prevent this from happening ever again? It is a great initiative that we fixed this but what guardrails there are for being sure this will not repeat? Do you think it would be possible to add a rule to checkstyle for tests (.build/checkstyle-test.xml) so it would fail if it ever sees 'new File("/tmp' again? Simple regexp search in IDEA tells that this pattern is happening exclusively in tests only. was (Author: smiklosovic): I am sorry I am stepping in to this ticket relatively late but I have this question ... Do not we want to prevent this from happening ever again? It it a great initiative that we fixed this but what guardrails there are for being sure this will not repeat? Do you think it would be possible to add a rule to checkstyle for tests (.build/checkstyle-test.xml) so it would fail if it ever sees 'new File("/tmp' again? Simple regexp search in IDEA tells that this pattern is happening exclusively in tests only. > Make unit tests compatible with the tmp.dir property > ---------------------------------------------------- > > Key: CASSANDRA-18750 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18750 > Project: Cassandra > Issue Type: Improvement > Components: Build > Reporter: Derek Chen-Becker > Assignee: Derek Chen-Becker > Priority: Normal > > Several unit tests hard-code file paths under the "/tmp" directory, which > means they do not honor the {{tmp.dir}} ant build property. These should be > updated so that when the user specifies {{tmp.dir}}, they can be certain that > any files or directories created by the unit tests will be in their specified > location. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org