[
https://issues.apache.org/jira/browse/CASSANDRA-14319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759640#comment-17759640
]
Ariel Weisberg edited comment on CASSANDRA-14319 at 8/28/23 4:46 PM:
---------------------------------------------------------------------
This seems to set {{isRebuilding}} to false when validating the input or
failing to {{isRebuilding.compareAndSet}} as part of the {{try/catch}} that is
introduced. Just because this thread is not able to proceed with rebuild
doesn't mean another thread isn't still proceeding.
I think the new {{try/catch}} should be removed and the
{{isRebuilding.compareAndSet}} should be in the existing {{try/catch}} that
sets {{isRebuilding}} to {{false}} if actually doing the rebuild fails.
was (Author: aweisberg):
This seems to set `isRebuilding` to false when validating the input or failing
to `isRebuilding.compareAndSet` as part of the `try/catch` that is introduced.
Just because this thread is not able to proceed with rebuild doesn't mean
another thread isn't still proceeding.
I think the new `try/catch` should be removed and the
`isRebuilding.compareAndSet` should be in the existing `try/catch` that sets
`isRebuilding` to `false` if actually doing the rebuild fails.
> nodetool rebuild from DC lets you pass invalid datacenters
> -----------------------------------------------------------
>
> Key: CASSANDRA-14319
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14319
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/nodetool
> Reporter: Jon Haddad
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 3.0.29, 3.11.16, 4.0.10, 4.1.2, 5.0
>
> Attachments: CASSANDRA-14319-trunk.txt
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> If you pass an invalid datacenter to nodetool rebuild, you'll get an error
> like this:
> {code}
> Unable to find sufficient sources for streaming range
> (3074457345618258602,-9223372036854775808] in keyspace system_distributed
> {code}
> Unfortunately, this is a rabbit hole of frustration if you are using caps for
> your DC names and you pass in a lowercase DC name, or you just typo the DC.
> Let's do the following:
> # Check the DC name that's passed in against the list of DCs we know about
> # If we don't find it, let's output a reasonable error, and list all the DCs
> someone could put in.
> # Ideally we indicate which keyspaces are set to replicate to this DC and
> which aren't
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
