[ https://issues.apache.org/jira/browse/CASSANDRA-18799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759967#comment-17759967 ]
Maxim Muzafarov edited comment on CASSANDRA-18799 at 8/29/23 2:01 PM: ---------------------------------------------------------------------- [~e.dimitrova] Thanks for noticing this, I also found that the upgrade is required to 0.7.1+ because of the following commit [d6a834338d0b7de5b79d10c95d1bc08d73238c63|https://github.com/snazy/ohc/commit/d6a834338d0b7de5b79d10c95d1bc08d73238c63]. The tests results for the latest changes are here: https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=cassandra-18799 #2489 (thank you for scheduling it!) Overall looks good. The results include a couple of failed tests, both of which I've run locally. The {{org.apache.cassandra.transport.CQLConnectionTest}} passes locally, and the second one has its own problem to fix: CASSANDRA-18361 Since the library is related to off-heap caching, I think the results that are the most interesting for us are {{j11_cqlsh_dtests_py311_offheap}} and {{j11_dtests_offheap}}, can you help to run them either? I've tried running them on my own CircleCI plan and failed with an error "Try out a larger resource class or running tests in parallel to speed up job execution.", it seems to me that Jenkins still doesn't work. was (Author: mmuzaf): [~e.dimitrova] Thanks for noticing this, I also found that the upgrade is required to 0.7.1+ because of the following commit [d6a834338d0b7de5b79d10c95d1bc08d73238c63|https://github.com/snazy/ohc/commit/d6a834338d0b7de5b79d10c95d1bc08d73238c63]. The tests results for the latest changes are here: https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=cassandra-18799 #2489 Overall looks good. The results include a couple of failed tests, both of which I've run locally. The {{org.apache.cassandra.transport.CQLConnectionTest}} passes locally, and the second one has its own problem to fix: CASSANDRA-18361 Since the library is related to off-heap caching, I think the results that are the most interesting for us are {{j11_cqlsh_dtests_py311_offheap}} and {{j11_dtests_offheap}}, can you help to run them either? I've tried running them on my own CircleCI plan and failed with an error "Try out a larger resource class or running tests in parallel to speed up job execution.", it seems to me that Jenkins still doesn't work. > Remove org.caffinitas.ohc:ohc-core-j8 dependency > ------------------------------------------------ > > Key: CASSANDRA-18799 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18799 > Project: Cassandra > Issue Type: Task > Components: Dependencies > Reporter: Maxim Muzafarov > Assignee: Maxim Muzafarov > Priority: Normal > Fix For: 5.0 > > Time Spent: 10m > Remaining Estimate: 0h > > It seems the `org.caffinitas.ohc:ohc-core-j8` is not required anymore and the > Cassandra project moved away from JDK8 support. The changes are here: > CASSANDRA-18255 > We can remove it. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org