[
https://issues.apache.org/jira/browse/CASSANDRA-18805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760138#comment-17760138
]
Ekaterina Dimitrova edited comment on CASSANDRA-18805 at 8/29/23 8:52 PM:
--------------------------------------------------------------------------
Version 3 comes with some breaking API changes, which I fixed -
[https://github.com/ben-manes/caffeine/releases/tag/v3.0.0]
The respective commits which introduced those:
[https://github.com/ben-manes/caffeine/commit/91eec88be93f16549ce82dd2f17959fd8eba75dd]
[https://github.com/ben-manes/caffeine/commit/e45837248905d752d7fbd7c8df3ed1a439d7af89]
[https://github.com/ben-manes/caffeine/commit/bfec59c146cf10ffe9b937563bf0d13beb5e1759]
This is also the full list of release notes -
https://github.com/ben-manes/caffeine/releases?page=2
CIDRPermissionsCache failed to compile as it seems some type safety was
introduced in the newer caffeine version, which caused a compilation failure
because we do a null check for String instead of RoleResource
[here|https://github.com/apache/cassandra/blob/cassandra-5.0/src/java/org/apache/cassandra/auth/CIDRPermissionsCache.java#L57].
Even in the current 5.0 code with the old version of caffeine I could compile
when I switched to RoleResource.role(roleName).
That change also makes sense when I look into the following line where we
invalidate using the key provided as RoleResource.role(roleName) -
[https://github.com/apache/cassandra/blob/cassandra-5.0/src/java/org/apache/cassandra/auth/CIDRPermissionsCache.java#L60].
Patch: [https://github.com/apache/cassandra/pull/2648]
CI:
[https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=caffeine-upgrade]
[~skoppu], [~yifanc], and [~djoshi] - do you mind taking a look? The change
made here is related to CASSANDRA-18592. I am unfamiliar with the code
introduced and might be missing something bigger here.
This is the 5.0 patch. When we confirm it, I can propagate it to the trunk, too
and test it.
was (Author: e.dimitrova):
Version 3 comes with some breaking API changes, which I fixed -
[https://github.com/ben-manes/caffeine/releases/tag/v3.0.0]
The respective commits which introduced those:
[https://github.com/ben-manes/caffeine/commit/91eec88be93f16549ce82dd2f17959fd8eba75dd]
[https://github.com/ben-manes/caffeine/commit/e45837248905d752d7fbd7c8df3ed1a439d7af89]
[https://github.com/ben-manes/caffeine/commit/bfec59c146cf10ffe9b937563bf0d13beb5e1759]
CIDRPermissionsCache failed to compile as it seems some type safety was
introduced in the newer caffeine version, which caused a compilation failure
because we do a null check for String instead of RoleResource
[here|https://github.com/apache/cassandra/blob/cassandra-5.0/src/java/org/apache/cassandra/auth/CIDRPermissionsCache.java#L57].
Even in the current 5.0 code with the old version of caffeine I could compile
when I switched to RoleResource.role(roleName).
That change also makes sense when I look into the following line where we
invalidate using the key provided as RoleResource.role(roleName) -
[https://github.com/apache/cassandra/blob/cassandra-5.0/src/java/org/apache/cassandra/auth/CIDRPermissionsCache.java#L60].
Patch: [https://github.com/apache/cassandra/pull/2648]
CI:
[https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra?branch=caffeine-upgrade]
[~skoppu], [~yifanc], and [~djoshi] - do you mind taking a look? The change
made here is related to CASSANDRA-18592. I am unfamiliar with the code
introduced and might be missing something bigger here.
This is the 5.0 patch. When we confirm it, I can propagate it to the trunk, too
and test it.
> Upgrade caffeine to 3.1.8
> -------------------------
>
> Key: CASSANDRA-18805
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18805
> Project: Cassandra
> Issue Type: Task
> Components: Dependencies
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 5.0.x, 5.x
>
>
> 3.1.8 is based on Java 11. This version is testing with newer JDK versions,
> while 2.x versions are based on JDK8, and as I understand, only bug-fix
> releases are expected.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
