[ 
https://issues.apache.org/jira/browse/CASSANDRA-18322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761819#comment-17761819
 ] 

Stefan Miklosovic edited comment on CASSANDRA-18322 at 9/5/23 8:43 AM:
-----------------------------------------------------------------------

Ah as I dug deeper I see what is the problem ... No need to create another 
ticket. 

I prepared a patch for trunk here (1). 

It applies cleanly back to 4.0. 

(1) https://github.com/apache/cassandra/pull/2668
(2) 3.11 PR https://github.com/apache/cassandra/pull/2669
(3) 3.0 PR https://github.com/apache/cassandra/pull/2670/files

I ll do builds when it is reviewed ... it is going to 6 branches so I do not 
want to build that prematurely.

[~brandon.williams] would you mind to take a look?


was (Author: smiklosovic):
Ah as I dug deeper I see what is the problem ... No need to create another 
ticket. 

I prepared a patch for trunk here (1). 

It applies cleanly back to 4.0. 

(1) https://github.com/apache/cassandra/pull/2668
(2) 3.11 PR https://github.com/apache/cassandra/pull/2669
(3) 3.0 PR https://github.com/apache/cassandra/pull/2670/files

I ll do builds when it is reviewed ... it is going to 6 branches so I do not 
want to build that prematurely.

> Warn about unqualified prepared statement only if it is a select, update, 
> delete, insert
> ----------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-18322
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18322
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Messaging/Client
>            Reporter: Mohammad Aburadeh
>            Assignee: Stefan Miklosovic
>            Priority: Urgent
>             Fix For: 3.0.x, 3.11.x, 4.0.x, 4.1.x, 5.x
>
>
> Hi, 
> We get the following warnings when we use prepared statements with "create 
> keyspace ... " or "drop keyspace" statements.
> "
> {{USE <keyspace>}} with prepared statements is considered to be an 
> anti-pattern due to ambiguity in non-qualified table names. Please consider 
> removing instances of {{{}Session#setKeyspace(<keyspace>){}}}, 
> {{Session#execute("USE <keyspace>")}} and {{cluster.newSession(<keyspace>)}} 
> from your code, and always use fully qualified table names (e.g. 
> <keyspace>.<table>). Keyspace used: null, statement keyspace: null, statement 
> id: 8153d922390fdf9a9963bfeda85b2f3b at 
> "
> Such statements are already full-qualified. So, why are we getting this 
> warning? 
> Regards
> Mohammad



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to