5 commented on code in PR #15:
URL:
https://github.com/apache/cassandra-analytics/pull/15#discussion_r1321846803
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/clients/Sidecar.java:
##########
@@ -129,6 +135,9 @@ public static SidecarClient from(SidecarInstancesProvider
sidecarInstancesProvid
.ssl(conf.hasKeystoreAndKeystorePassword())
.build();
+ StartupValidator.instance().register(new
KeystoreValidation(secretsProvider));
+ StartupValidator.instance().register(new
TruststoreValidation(secretsProvider));
+
SidecarConfig sidecarConfig = new SidecarConfig.Builder()
Review Comment:
I am confused by this comment, seems to still exist/compile for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
