[ https://issues.apache.org/jira/browse/CASSANDRA-18841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17765844#comment-17765844 ]
Doug Rohrer commented on CASSANDRA-18841: ----------------------------------------- Yeah - I agree that there are clearly other places where we probably need a {{sync}} call, or even if we don't +technically+ need one now, not having them opens us up to repeats of this particular bug if something deep in the bowls of one of those calls ends up touching a thread local variable, so it would be good to review the other non-{{sync}} ed methods, and perhaps provide some guidance on when we can skip calling {{sync}} (maybe almost never?) > InstanceClassLoader leak in 5.0/trunk > ------------------------------------- > > Key: CASSANDRA-18841 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18841 > Project: Cassandra > Issue Type: Bug > Components: Test/dtest/java > Reporter: Doug Rohrer > Assignee: Doug Rohrer > Priority: Normal > Fix For: 4.1.4, 5.0-alpha2, 5.1 > > Attachments: trunk_ThreadLocal_leak.patch > > Time Spent: 0.5h > Remaining Estimate: 0h > > Something in the 5.0/trunk branches has caused an in-jvm dtest > InstanceClassLoader leak - it appears to have something to do with the Mutual > TLS Authenticator (f078c02cb58bddd735490b07548f7352f0eb09aa) but nothing in > that commit, so far, has stood out as causing issues. > The culprit class appears to be > {{io.netty.util.internal.InternalThreadLocalMap}}, which seems to no be > removed when the threads stops for some reason. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org