[
https://issues.apache.org/jira/browse/CASSANDRA-18813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766385#comment-17766385
]
Ekaterina Dimitrova commented on CASSANDRA-18813:
-------------------------------------------------
The correct CI links are these, confirmed with [~blerer]:
[Java11|https://app.circleci.com/pipelines/github/blerer/cassandra/359/workflows/8a5c3201-3b8e-4c45-b953-f06860ed925e]
*org.apache.cassandra.distributed.test.FailingRepairTest-.jdk11* - I did not
find a ticket for this one, but I've seen something similar. Let's loop it on
the current trunk and open another ticket when it confirms it is unrelated to
what we do here.
*testDropListAndAddListWithSameName-.jdk11* - CASSANDRA-18360
I would also recommend running the upgrade tests before committing.
I am still reviewing it, though.
> Simplify the bind marker and Term logic
> ---------------------------------------
>
> Key: CASSANDRA-18813
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18813
> Project: Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
> Reporter: Benjamin Lerer
> Assignee: Benjamin Lerer
> Priority: Normal
> Fix For: 5.x
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The current logic around {{Term}} and {{Terms}} classes is confusing
> specially with {{MultiItemTerminal}} and {{MultiColumnRaw}} that are used to
> handle different use cases that could be handled simply with the {{Term}}
> interface.
> On top of that IN marker add to the confusion because the are represented as
> single Term where in practice they are a set of terms. Representing them as a
> {{Terms}} could simplify the way we handle IN restrictions.
> The goal of this ticket is:
> * to refactor the {{Term}} and {{Terms}} interfaces to simplify the logic
> * Represents IN bind marker as {{Terms}} instead of having 2 different
> representations (a list of terms and a single {{MultiItemTerminal}}.
> * Simplify the {{AbstractMarker}} hierachy
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
