[ https://issues.apache.org/jira/browse/CASSANDRA-18836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767193#comment-17767193 ]
Caleb Rackliffe commented on CASSANDRA-18836: --------------------------------------------- I think we have to change both. Take {{META}} files as an example. Those are written w/ what we get from {{IndexDescriptor#openPerIndexOutput()}} and read w/ what we get from {{IndexDescriptor#openPerIndexInput()}}. (See {{MetadataSource.load()}}) They have to use the same CRC algorithm, right? > Replace CRC32 w/ CRC32C in IndexFileUtils.ChecksummingWriter > ------------------------------------------------------------ > > Key: CASSANDRA-18836 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18836 > Project: Cassandra > Issue Type: Improvement > Components: Feature/2i Index, Feature/SAI > Reporter: Caleb Rackliffe > Assignee: Maxim Muzafarov > Priority: Normal > Fix For: 5.0-alpha2, 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > It seems that now we're on Java 11 for 5.0, there isn't much reason not to > use CRC32C as a drop-in replacement for CRC32. SAI isn't even released, so > has no binary compatibility entanglements, and this should be pretty > straightforward. > See https://github.com/apache/bookkeeper/pull/3309 -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org