[ https://issues.apache.org/jira/browse/CASSANDRA-17062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17767275#comment-17767275 ]
Stefan Miklosovic commented on CASSANDRA-17062: ----------------------------------------------- I moved this forward here (1) We got new auth caches in the meanwhile - CIDR auth cache and Identity cache from Mutual TLS authenticator (both if enabled) so I exposed them too if configured. The original patch was also propagating these metrics to nodetool info because there are currently caches like key / row / counter / network cache but I do not like that we are exposing it in this nodetool command. It just does not feel natural. I think that it is just better to have it only in cqlsh so I can remove them if we agree on that. It would be great to have some review! ([~samt] I know you are busy ...) [~bereng] I see you among watchers, maybe you would give it a shot? [~paulo] likewise. {code} $ ./bin/nodetool info ID : c8be5408-d1b1-433f-b124-6b7a8c76b1bb Gossip active : true Native Transport active : true Load : 252.6 KiB Uncompressed load : 332.68 KiB Generation No : 1695240794 Uptime (seconds) : 42 Heap Memory (MB) : 243.66 / 989.88 Off Heap Memory (MB) : 0.00 Data Center : datacenter1 Rack : rack1 Exceptions : 0 Key Cache : entries 11, size 984 bytes, capacity 46 MiB, 104 hits, 118 requests, 0.881 recent hit rate, 14400 save period in seconds Row Cache : entries 0, size 0 bytes, capacity 0 bytes, 0 hits, 0 requests, NaN recent hit rate, 0 save period in seconds Counter Cache : entries 0, size 0 bytes, capacity 23 MiB, 0 hits, 0 requests, NaN recent hit rate, 7200 save period in seconds Network Cache : size 8 MiB, overflow size: 0 bytes, capacity 61 MiB Credentials Cache : entries 1, capacity 1000, 1 hits, 2 requests, 0.500 recent hit rate JMX Permissions Cache : entries 0, capacity 1000, 0 hits, 0 requests, NaN recent hit rate Network Permissions Cache: entries 1, capacity 1000, 30 hits, 32 requests, 0.938 recent hit rate Permissions Cache : entries 1, capacity 1000, 2 hits, 17 requests, 0.118 recent hit rate Roles Cache : entries 1, capacity 1000, 37 hits, 39 requests, 0.949 recent hit rate CIDR Permissions Cache : entries 1, capacity 1000, 30 hits, 32 requests, 0.938 recent hit rate Percent Repaired : 100.0% Token : (invoke with -T/--tokens to see all 16 tokens) Bootstrap state : COMPLETED Bootstrap failed : false Decommissioning : false Decommission failed : false {code} (1) https://github.com/apache/cassandra/pull/2710 > Expose Auth Caches metrics > -------------------------- > > Key: CASSANDRA-17062 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17062 > Project: Cassandra > Issue Type: Improvement > Components: Feature/Virtual Tables, Observability/Metrics, > Tool/nodetool > Reporter: Aleksei Zotov > Assignee: Stefan Miklosovic > Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > Unlike to other caches (row, key, counter), Auth Caches lack some monitoring > capabilities. Here are a few particular changes to get this inequity fixed: > # Add auth caches to _system_views.caches_ VT > # Expose auth caches metrics via JMX > # Add auth caches details to _nodetool info_ > -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org