dineshjoshi commented on code in PR #15:
URL:
https://github.com/apache/cassandra-analytics/pull/15#discussion_r1334732728
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/CassandraDataLayer.java:
##########
@@ -685,6 +700,7 @@ private void readObject(ObjectInputStream in) throws
IOException, ClassNotFoundE
}
this.rfMap = (Map<String, ReplicationFactor>) in.readObject();
this.initInstanceMap();
+ this.startupValidate();
Review Comment:
Shouldn't this be performed _before_ `initInstanceMap`? `initInstanceMap`
will likely reach out to external services to build the instance map and may
fail to retrieve information? This would defeat the purpose of using
`startupValidate`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
