[ 
https://issues.apache.org/jira/browse/CASSANDRA-18816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769090#comment-17769090
 ] 

Marcus Eriksson commented on CASSANDRA-18816:
---------------------------------------------

+1

it looks like some of the code was copied from elsewhere (like 
SimulatedExecutorFactory looks very similar to classes in Accord, and you 
mentioned in the PR that some of the Backoff code was copied from hadoop?) - it 
would have simplified review a lot if that would have been mentioned in 
comments.

> Add support for repair coordinator to retry messages that timeout
> -----------------------------------------------------------------
>
>                 Key: CASSANDRA-18816
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18816
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Consistency/Repair
>            Reporter: David Capwell
>            Assignee: David Capwell
>            Priority: Normal
>             Fix For: 5.x
>
>          Time Spent: 11h 40m
>  Remaining Estimate: 0h
>
> Now that CASSANDRA-15399 is in, most of the repair messages have a state that 
> they can check against to make message delivery idempotent, allowing the 
> coordinator to retry such messages; a few of the most critical messages to 
> retry are: PREPARE_MSG, VALIDATION_REQ, VALIDATION_RSP, SYNC_REQ, and 
> SYNC_RSP.
> With this I propose making the coordinator able to retry these key messages 
> to try and make repair more resilient to ephemeral issues.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to