[ https://issues.apache.org/jira/browse/CASSANDRA-18893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770598#comment-17770598 ]
Ekaterina Dimitrova edited comment on CASSANDRA-18893 at 9/29/23 10:34 PM: --------------------------------------------------------------------------- The only CI failure is test_failing_manual_rebuild_index - CASSANDRA-18361. Looking into the commits, I see fixes, and in 2.1.12 there is added PackedHistogram ([https://www.javadoc.io/doc/org.hdrhistogram/HdrHistogram/latest/index.html]). So nothing that is breaking us? I suggest we port it also to 4.0, 4.1 or at least bump it to version 2.1.10 there. Not sure whether we need to hit the ML for pre-5.0 branches. I will wait for a reviewer's feedback. [~brandon.williams] , [~toblin], do you mind reviewing? :) was (Author: e.dimitrova): The only CI failure is test_failing_manual_rebuild_index - CASSANDRA-18361. Looking into the commits, I see fixes, and in 2.1.12 there is added PackedHistogram ([https://www.javadoc.io/doc/org.hdrhistogram/HdrHistogram/latest/index.html]). So nothing that is breaking us? I suggest we port it also to 4.0, or at least version 2.1.10. Not sure whether we need to hit the ML for pre-5.0 branches. I will wait for a reviewer's feedback. [~brandon.williams] , [~toblin], do you mind reviewing? :) > Upgrade hdrhistogram > -------------------- > > Key: CASSANDRA-18893 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18893 > Project: Cassandra > Issue Type: Task > Components: Dependencies > Reporter: Ekaterina Dimitrova > Assignee: Ekaterina Dimitrova > Priority: Normal > Fix For: 5.0.x, 5.x > > > We are on 2.1.9, but some breaking changes for J9+ were introduced only in > 2.1.10 (we don't hit them in our CI but a user reported they saw NoClassFound > in some testing) > https://github.com/HdrHistogram/HdrHistogram/commit/c410c5c2699b69ce0eb026ff954fefc4045ec363 -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org