[ 
https://issues.apache.org/jira/browse/CASSANDRA-18747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774828#comment-17774828
 ] 

Benjamin Lerer commented on CASSANDRA-18747:
--------------------------------------------

It seems to me that the proposed solution is going in the opposite direction of 
where it should go. The issue mainly comes from the fact that we have 
duplicated some information in a multithreaded code. Rather than making that 
logic more complex we should simplify it an remove the duplication. Looking at 
where those 2 variables are used and how they get used I really do not see the 
need for the {{distributedAndLocalKeyspaces}} variable. Am I missing something?

> Test failure: Fix assertion error AssertionError: Unknown keyspace 
> system_auth\n\tat 
> org.apache.cassandra.db.Keyspace.<init>(Keyspace.java:324)\n\tat 
> org.apache.cassandra.db.Keyspace.lambda$open$0(Keyspace.java:162)
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-18747
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18747
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Cluster/Schema, Test/dtest/python
>            Reporter: Ekaterina Dimitrova
>            Assignee: Jacek Lewandowski
>            Priority: Normal
>             Fix For: 4.1.x, 5.0.x, 5.x
>
>          Time Spent: 6h 50m
>  Remaining Estimate: 0h
>
> I've been seeing this assertion error in different tests lately.
> Full error message:
> {code:java}
> failed on teardown with "Unexpected error found in node logs (see stdout for 
> full details). Errors: [[node2] 'ERROR [PendingRangeCalculator:1] 2023-08-11 
> 16:35:14,445 JVMStabilityInspector.java:70 - Exception in thread 
> Thread[PendingRangeCalculator:1,5,PendingRangeCalculator]\njava.lang.AssertionError:
>  Unknown keyspace system_auth\n\tat 
> org.apache.cassandra.db.Keyspace.<init>(Keyspace.java:324)\n\tat 
> org.apache.cassandra.db.Keyspace.lambda$open$0(Keyspace.java:162)\n\tat 
> org.apache.cassandra.utils.concurrent.LoadingMap.blockingLoadIfAbsent(LoadingMap.java:105)\n\tat
>  
> org.apache.cassandra.schema.Schema.maybeAddKeyspaceInstance(Schema.java:251)\n\tat
>  org.apache.cassandra.db.Keyspace.open(Keyspace.java:162)\n\tat 
> org.apache.cassandra.db.Keyspace.open(Keyspace.java:151)\n\tat 
> org.apache.cassandra.service.PendingRangeCalculatorService.lambda$new$1(PendingRangeCalculatorService.java:58)\n\tat
>  
> org.apache.cassandra.concurrent.SingleThreadExecutorPlus$AtLeastOnce.run(SingleThreadExecutorPlus.java:60)\n\tat
>  
> org.apache.cassandra.concurrent.ExecutionFailure$1.run(ExecutionFailure.java:133)\n\tat
>  
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)\n\tat
>  
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)\n\tat
>  
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)\n\tat
>  java.base/java.lang.Thread.run(Thread.java:829)']" Unexpected error found in 
> node logs (see stdout for full details). Errors: [[node2] 'ERROR 
> [PendingRangeCalculator:1] 2023-08-11 16:35:14,445 
> JVMStabilityInspector.java:70 - Exception in thread 
> Thread[PendingRangeCalculator:1,5,PendingRangeCalculator]\njava.lang.AssertionError:
>  Unknown keyspace system_auth\n\tat 
> org.apache.cassandra.db.Keyspace.<init>(Keyspace.java:324)\n\tat 
> org.apache.cassandra.db.Keyspace.lambda$open$0(Keyspace.java:162)\n\tat 
> org.apache.cassandra.utils.concurrent.LoadingMap.blockingLoadIfAbsent(LoadingMap.java:105)\n\tat
>  
> org.apache.cassandra.schema.Schema.maybeAddKeyspaceInstance(Schema.java:251)\n\tat
>  org.apache.cassandra.db.Keyspace.open(Keyspace.java:162)\n\tat 
> org.apache.cassandra.db.Keyspace.open(Keyspace.java:151)\n\tat 
> org.apache.cassandra.service.PendingRangeCalculatorService.lambda$new$1(PendingRangeCalculatorService.java:58)\n\tat
>  
> org.apache.cassandra.concurrent.SingleThreadExecutorPlus$AtLeastOnce.run(SingleThreadExecutorPlus.java:60)\n\tat
>  
> org.apache.cassandra.concurrent.ExecutionFailure$1.run(ExecutionFailure.java:133)\n\tat
>  
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)\n\tat
>  
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)\n\tat
>  
> io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)\n\tat
>  java.base/java.lang.Thread.run(Thread.java:829)']{code}
> Example failures:
> test_failed_snitch_update_property_file_snitch - 
> [https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/2475/workflows/2086619e-0f21-464b-a866-84aca516b5e5/jobs/36716/tests]
> test_gcgs_validation - 
> [https://ci-cassandra.apache.org/job/Cassandra-trunk/1666/testReport/junit/dtest.materialized_views_test/TestMaterializedViews/test_gcgs_validation/]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to