[ https://issues.apache.org/jira/browse/CASSANDRA-18872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17777333#comment-17777333 ]
Branimir Lambov commented on CASSANDRA-18872: --------------------------------------------- The patch looks good to me, the changes are not too invasive and can be easily replaced with format configuration in CASSANDRA-18534. Do we have a documentation ticket corresponding to this? AFAICS [the docs|https://cassandra.apache.org/doc/latest/cassandra/operating/compression.html] only mention the compression-level setting, even for 4.1. This documentation change also needs to explain that the chance only applies to compressed sstables. > Remove deprecated crc_check_chance in compression params > -------------------------------------------------------- > > Key: CASSANDRA-18872 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18872 > Project: Cassandra > Issue Type: Task > Components: Feature/Compression, Legacy/CQL > Reporter: Stefan Miklosovic > Assignee: Stefan Miklosovic > Priority: Normal > Fix For: 5.x > > Time Spent: 20m > Remaining Estimate: 0h > > crc_check_chance was moved from compression parameters and it is a standalone > table parameter. This was done in times of 3.0 so it is now time to get rid > of that in 5.0. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org