[ https://issues.apache.org/jira/browse/CASSANDRA-18775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17777794#comment-17777794 ]
Claude Warren edited comment on CASSANDRA-18775 at 10/20/23 2:08 PM: --------------------------------------------------------------------- I think that preserving any sigar library where the file name contains the word "linux" or "macosx" should be acceptable. This will preserve: libsigar-amd64-linux.so libsigar-ia64-linux.so libsigar-ppc-linux.so libsigar-ppc64-linux.so libsigar-ppc64le-linux.so libsigar-s390x-linux.so libsigar-universal-macosx.dylib libsigar-universal64-macosx.dylib libsigar-x86-linux.so and remove: libsigar-amd64-freebsd-6.so libsigar-amd64-solaris.so libsigar-ia64-hpux-11.sl libsigar-pa-hpux-11.sl libsigar-ppc-aix-5.so libsigar-ppc64-aix-5.so libsigar-sparc-solaris.so libsigar-sparc64-solaris.so libsigar-x86-freebsd-5.so libsigar-x86-freebsd-6.so libsigar-x86-solaris.so resulting in a savings of 3530461 bytes out of 6,450,526 from the /lib/sigar-bin directory, an approximately 50% reduction. Does anyone see any reason _not_ to do this? was (Author: claudenw): I think that preserving any sigar library where the file name contains the word "linux" or "macosx" should be acceptable. This will preserve: libsigar-amd64-linux.so libsigar-ia64-linux.so libsigar-ppc-linux.so libsigar-ppc64-linux.so libsigar-ppc64le-linux.so libsigar-s390x-linux.so libsigar-universal-macosx.dylib libsigar-universal64-macosx.dylib libsigar-x86-linux.so and remove: libsigar-amd64-freebsd-6.solibsigar-amd64-solaris.so libsigar-ia64-hpux-11.sl libsigar-pa-hpux-11.sl libsigar-ppc-aix-5.solibsigar-ppc64-aix-5.so libsigar-sparc-solaris.so libsigar-sparc64-solaris.so libsigar-x86-freebsd-5.so libsigar-x86-freebsd-6.so libsigar-x86-solaris.so resulting in a savings of 3530461 bytes out of 6,450,526 from the /lib/sigar-bin directory, a 48% reduction. Does anyone see any reason _not_ to do this? > Remove libraries in lib/sigar-bin for unsupported architectures > --------------------------------------------------------------- > > Key: CASSANDRA-18775 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18775 > Project: Cassandra > Issue Type: Task > Components: Dependencies > Reporter: Stefan Miklosovic > Assignee: Maxim Muzafarov > Priority: Normal > Fix For: 5.x > > > {code} > ✔ ~/dev/cassandra/cassandra-instaclustr/cassandra [trunk L|⚑ 49] > 15:41 $ ls -la lib/sigar-bin/ > total 6376 > drwxrwxr-x 2 fermat fermat 4096 aug 17 11:26 . > drwxrwxr-x 5 fermat fermat 12288 aug 17 11:28 .. > -rw-rw-r-- 1 fermat fermat 210641 aug 17 11:26 libsigar-amd64-freebsd-6.so > -rw-rw-r-- 1 fermat fermat 246605 aug 17 11:26 libsigar-amd64-linux.so > -rw-rw-r-- 1 fermat fermat 251360 aug 17 11:26 libsigar-amd64-solaris.so > -rw-rw-r-- 1 fermat fermat 577452 aug 17 11:26 libsigar-ia64-hpux-11.sl > -rw-rw-r-- 1 fermat fermat 494929 aug 17 11:26 libsigar-ia64-linux.so > -rw-rw-r-- 1 fermat fermat 516096 aug 17 11:26 libsigar-pa-hpux-11.sl > -rw-rw-r-- 1 fermat fermat 425077 aug 17 11:26 libsigar-ppc64-aix-5.so > -rw-rw-r-- 1 fermat fermat 310792 aug 17 11:26 libsigar-ppc64le-linux.so > -rw-rw-r-- 1 fermat fermat 330767 aug 17 11:26 libsigar-ppc64-linux.so > -rw-rw-r-- 1 fermat fermat 400925 aug 17 11:26 libsigar-ppc-aix-5.so > -rw-rw-r-- 1 fermat fermat 258547 aug 17 11:26 libsigar-ppc-linux.so > -rw-rw-r-- 1 fermat fermat 269932 aug 17 11:26 libsigar-s390x-linux.so > -rw-rw-r-- 1 fermat fermat 261896 aug 17 11:26 libsigar-sparc64-solaris.so > -rw-rw-r-- 1 fermat fermat 285004 aug 17 11:26 libsigar-sparc-solaris.so > -rw-rw-r-- 1 fermat fermat 397440 aug 17 11:26 > libsigar-universal64-macosx.dylib > -rw-rw-r-- 1 fermat fermat 377668 aug 17 11:26 libsigar-universal-macosx.dylib > -rw-rw-r-- 1 fermat fermat 179751 aug 17 11:26 libsigar-x86-freebsd-5.so > -rw-rw-r-- 1 fermat fermat 179379 aug 17 11:26 libsigar-x86-freebsd-6.so > -rw-rw-r-- 1 fermat fermat 233385 aug 17 11:26 libsigar-x86-linux.so > -rw-rw-r-- 1 fermat fermat 242880 aug 17 11:26 libsigar-x86-solaris.so > ✔ ~/dev/cassandra/cassandra-instaclustr/cassandra [trunk L|⚑ 49] > 15:43 $ du -shc lib/sigar-bin/ > 6,3M lib/sigar-bin/ > 6,3M total > {code} > I think we could definitely improve this. We basically need just x86-linux, > amd64-linux and two libs for macosx. > We could save like 5M from the final tarball size. From 75M down to 70M is > not bad! > Or maybe I am not getting something and we need this? -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org