[ https://issues.apache.org/jira/browse/CASSANDRA-18952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778837#comment-17778837 ]
David Capwell commented on CASSANDRA-18952: ------------------------------------------- bq. Looks like you raised these two PRs against the 5.0 branch, its only 1 PR and its for review. Once the review is close to done I will create a trunk version as well; keeping 2 in-sync is easier to get wrong IMO. bq. Do we need to write tests for these metrics? if people want I can add... I see them update in the existing tests; doesn't mean they won't break later on... > Add metrics and logging to repair retries > ----------------------------------------- > > Key: CASSANDRA-18952 > URL: https://issues.apache.org/jira/browse/CASSANDRA-18952 > Project: Cassandra > Issue Type: Improvement > Components: Consistency/Repair, Observability/Metrics > Reporter: David Capwell > Assignee: David Capwell > Priority: Normal > Fix For: 5.0.x, 5.x > > Time Spent: 1h 10m > Remaining Estimate: 0h > > In CASSANDRA-18816 we added repair message retries but forgot to add logging > and metrics to actually let operators know repairs happened and how often… we > should add such visibility to help operators know how best to tune it for > their environment. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org