[
https://issues.apache.org/jira/browse/CASSANDRASC-81?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yifan Cai updated CASSANDRASC-81:
---------------------------------
Reviewers: Arjun Ashok, Yifan Cai
Status: Review In Progress (was: Patch Available)
In principle, I would prefer to not changing the code in sidecar for the
purpose of improving the performance at the consumer. The consumer can build
the map for lookup if desired. There is nothing wrong regarding the correctness
of the response value of the endpoint.
Given the new endpoint implementation is newly added and it is only used in
cassandra analytics, I would consider it as a followup fix of the original
JIRA, CASSANDRASC-60.
+1 on the patch.
Please attach the CI link.
> Improve TokenRangeReplicasResponse payload
> ------------------------------------------
>
> Key: CASSANDRASC-81
> URL: https://issues.apache.org/jira/browse/CASSANDRASC-81
> Project: Sidecar for Apache Cassandra
> Issue Type: Improvement
> Components: Rest API
> Reporter: Francisco Guerrero
> Assignee: Francisco Guerrero
> Priority: Normal
> Labels: pull-request-available
>
> The {{TokenRangeReplicasResponse}} returns {{ReplicaMetadata}}. This
> information is used by clients to lookup the metadata. The lookup is done
> with the replica information, which consists of the host {{ip:port}}. Clients
> are looping over the {{ReplicaMetadata}} list and matching IP and port to
> retrieve the metadata object. Instead, we can improve the payload by changing
> the data structure from a list to a map, and have clients lookup by the
> replica (ip + port), without having to loop.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
