[ 
https://issues.apache.org/jira/browse/CASSANDRA-18956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Miklosovic updated CASSANDRA-18956:
------------------------------------------
    Reviewers: Stefan Miklosovic, Stefan Miklosovic  (was: Stefan Miklosovic)
               Stefan Miklosovic, Stefan Miklosovic  (was: Stefan Miklosovic)
       Status: Review In Progress  (was: Patch Available)

> Metadata Loss caused by unchecked rename column when upgrading from 2.x to 
> 3.0.29
> ---------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-18956
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18956
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Legacy/Distributed Metadata
>            Reporter: Ke Han
>            Assignee: Ke Han
>            Priority: Normal
>             Fix For: 3.0.x
>
>         Attachments: data.tar.gz, signature.asc, signature.asc, signature.asc
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> After migrating data from 2.1.22 (released 2022-06-17) to 3.0.29 (released 
> 2023-05-05), if user performs a rename operation to rename the primary key to 
> an existing column, it will succeed, and the original column will get lost 
> permanently.
> h1. Reproduce
> Start up single cassandra node 2.1.22
> Start up *cassandra-cli*
> {code:java}
> bin/cassandra-cli {code}
> Execute the following commands using cassandra-cli interface
> {code:java}
> create keyspace test with strategy_options = {replication_factor:1} and 
> placement_strategy = 'org.apache.cassandra.locator.SimpleStrategy';
> use test;
> create column family foos 
> with column_type = 'Standard' 
> and comparator = 'BytesType'
> and key_validation_class = 'UTF8Type' 
> and column_metadata = [{column_name: '2f', validation_class: 'UTF8Type'}]; 
> {code}
> Stop the daemon
> {code:java}
> bin/nodetool -h ::FFFF:127.0.0.1 stopdaemon {code}
> Upgrade, start up new version, start up cqlsh with *bin/cqlsh*
> {code:java}
> cqlsh> desc test.foos ;
> CREATE TABLE test.foos (
>     key text PRIMARY KEY,
>     "2f" text
> ) WITH COMPACT STORAGE
>     AND bloom_filter_fp_chance = 0.01
>     AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'}
>     AND comment = ''
>     AND compaction = {'class': 
> 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy', 
> 'max_threshold': '32', 'min_threshold': '4'}
>     AND compression = {'chunk_length_in_kb': '64', 'class': 
> 'org.apache.cassandra.io.compress.LZ4Compressor'}
>     AND crc_check_chance = 1.0
>     AND dclocal_read_repair_chance = 0.1
>     AND default_time_to_live = 0
>     AND gc_grace_seconds = 864000
>     AND max_index_interval = 2048
>     AND memtable_flush_period_in_ms = 0
>     AND min_index_interval = 128
>     AND read_repair_chance = 0.0
>     AND speculative_retry = 'NONE';
> cqlsh> ALTER TABLE test.foos RENAME key TO "2f";
> cqlsh> desc test.foos ;
> CREATE TABLE test.foos (
>     "2f" text PRIMARY KEY
> ) WITH COMPACT STORAGE
>     AND bloom_filter_fp_chance = 0.01
>     AND caching = {'keys': 'ALL', 'rows_per_partition': 'NONE'}
>     AND comment = ''
>     AND compaction = {'class': 
> 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy', 
> 'max_threshold': '32', 'min_threshold': '4'}
>     AND compression = {'chunk_length_in_kb': '64', 'class': 
> 'org.apache.cassandra.io.compress.LZ4Compressor'}
>     AND crc_check_chance = 1.0
>     AND dclocal_read_repair_chance = 0.1
>     AND default_time_to_live = 0
>     AND gc_grace_seconds = 864000
>     AND max_index_interval = 2048
>     AND memtable_flush_period_in_ms = 0
>     AND min_index_interval = 128
>     AND read_repair_chance = 0.0
>     AND speculative_retry = 'NONE';
> cqlsh> SELECT * FROM test.foos ;
>  2f
> ----
> (0 rows) {code}
> h1. Root Cause
> The root cause is a missing check for the existing column when the table 
> comparator from the old version is BytesType.
> I have uploaded the data dir, use it to start up 3.0.29 and execute the 
> commands will reproduce this bug.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to