[
https://issues.apache.org/jira/browse/CASSANDRA-19012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784450#comment-17784450
]
Sam Tunnicliffe commented on CASSANDRA-19012:
---------------------------------------------
I've been thinking about SCM and how it relates to tests. As the default is
{{StorageCompatibilityMode.CASSANDRA_4}}, I don't think that any of the
non-upgrade dtests are reading or writing `oa` sstables. Maybe this isn't a
great worry as that's mostly a local concern and should be covered by unit
tests*, but it does seem like a bit strange if dtests exclusively exercise the
system in what should ultimately be a temporary mode.
Regarding upgrade tests, I _think_ there is one in-jvm dtest
({{MixedModeMixedModeTTLOverflowUpgradeTest}} which goes all the way from 4.x
to 5.0/trunk with `StorageCompatibilityMode.NONE`, which is for the specific
expiration issue from CASSANDRA-14227. Is this coverage sufficient? (genuine
question).
* I think this requires a specific test target to be run, so the default `ant
test` target will never involve reads/writes of the latest SSTable format.
> It should be possible to read all supported versions of sstables regardless
> of the compatibility mode
> -----------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-19012
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19012
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jacek Lewandowski
> Priority: Normal
> Fix For: 5.0.x
>
>
> Currently when the storage compatibility mode is set to 4, it set the current
> write version of the ssatable to the latest compatible with 4 (N). However,
> it additionally make new sstables (O) recognized as invalid, which is wrong.
> We should be able to read all versions of supported sstables regardless of
> the compatibility mode.
> We should also ensure testing the scenario when the node tries to stream the
> new format sstable (node with compat mode = upgrading) to a node with compat
> mode = 4 - the test should demonstrate that such streaming is refused
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
