[ https://issues.apache.org/jira/browse/CASSANDRA-19000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17784971#comment-17784971 ]
Ekaterina Dimitrova edited comment on CASSANDRA-19000 at 11/10/23 2:42 PM: --------------------------------------------------------------------------- {quote}Agree, the exclusion should work. One might think that the {{close()}} calls for the driver's cluster and session in the try-with-resources at [{{NativeSSTableLoaderClient#init()}}|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/NativeSSTableLoaderClient.java#L70] should synchronously stop all the driver threads. But that doesn't seem to be the case according to the Jenkins-only test failure. I guess it's a driver thing and we can just exclude those threads from the test, maybe adding a comment? {quote} That is a good point, to be sure I am not just covering a driver bug, I just pinged [~absurdfarce] in Slack. If it is a driver bug we need a ticket and we do not want to cover it with exclusion. I will update the ticket when I hear from [~absurdfarce] was (Author: e.dimitrova): {quote}Agree, the exclusion should work. One might think that the {{close()}} calls for the driver's cluster and session in the try-with-resources at [{{NativeSSTableLoaderClient#init()}}|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/utils/NativeSSTableLoaderClient.java#L70] should synchronously stop all the driver threads. But that doesn't seem to be the case according to the Jenkins-only test failure. I guess it's a driver thing and we can just exclude those threads from the test, maybe adding a comment? {quote} That is a good point, to be sure I am not just covering a driver bug, I just pinged [~absurdfarce] in Slack. If it is a driver bug we need a ticket and we do not to cover it with exclusion. I will update the ticket when I hear from [~absurdfarce] > Test Failure: > org.apache.cassandra.tools.BulkLoaderTest.testBulkLoader_WithArgs2 > -------------------------------------------------------------------------------- > > Key: CASSANDRA-19000 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19000 > Project: Cassandra > Issue Type: Bug > Components: CI > Reporter: Ekaterina Dimitrova > Assignee: Ekaterina Dimitrova > Priority: Normal > Fix For: 4.0.x, 4.1.x, 5.0-rc, 5.x > > > h3. > https://ci-cassandra.apache.org/job/Cassandra-trunk/1766/testReport/org.apache.cassandra.tools/BulkLoaderTest/testBulkLoader_WithArgs2_cdc_jdk17_arch_x86_64_python2_7/ > {code:java} > Error Message > Wrong thread status, active threads unaccounted for: [cluster3-nio-worker-0] > Stacktrace > junit.framework.AssertionFailedError: Wrong thread status, active threads > unaccounted for: [cluster3-nio-worker-0] at > org.apache.cassandra.tools.OfflineToolUtils.assertNoUnexpectedThreadsStarted(OfflineToolUtils.java:120) > at > org.apache.cassandra.tools.BulkLoaderTest.testBulkLoader_WithArgs2(BulkLoaderTest.java:129) > at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native > Method) at > java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) > at > java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > {code} > -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org