[
https://issues.apache.org/jira/browse/CASSANDRA-18947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789011#comment-17789011
]
Berenguer Blasi edited comment on CASSANDRA-18947 at 11/23/23 8:07 AM:
-----------------------------------------------------------------------
It's just adding a stop like in this
[PR|https://github.com/apache/cassandra-dtest/pull/242]. As we're only looking
at _local data folders_ to be balanced having the node stopped seems like a
good idea. The other test cases revolve around bootstrap and other operator
alike commands so I wouldn't touch them for the time being.
was (Author: bereng):
It's just adding a stop like in this
[PR|https://github.com/apache/cassandra-dtest/pull/242]. As we're only looking
at _local data folders_ to be balanced having the node stopped seems like a
good idea. I would look/extend to the other test cases if applicable.
> Test failure:
> dtest-novnode.disk_balance_test.TestDiskBalance.test_disk_balance_stress
> --------------------------------------------------------------------------------------
>
> Key: CASSANDRA-18947
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18947
> Project: Cassandra
> Issue Type: Bug
> Components: Test/dtest/python
> Reporter: Ekaterina Dimitrova
> Assignee: Berenguer Blasi
> Priority: Normal
> Fix For: 5.0-rc
>
>
> Seen here:
> https://ci-cassandra.apache.org/job/Cassandra-5.0/72/testReport/dtest-novnode.disk_balance_test/TestDiskBalance/test_disk_balance_stress/
> h3.
> {code:java}
> Error Message
> AssertionError: values not within 10.00% of the max: (2534183, 2762123,
> 2423706) (node1)
> Stacktrace
> self = <disk_balance_test.TestDiskBalance object at 0x7f8fae9b7590> def
> test_disk_balance_stress(self): cluster = self.cluster if
> self.dtest_config.use_vnodes:
> cluster.set_configuration_options(values={'num_tokens': 256})
> cluster.populate(4).start() node1 = cluster.nodes['node1']
> node1.stress(['write', 'n=50k', 'no-warmup', '-rate', 'threads=100',
> '-schema', 'replication(factor=3)',
> 'compaction(strategy=SizeTieredCompactionStrategy,enabled=false)'])
> cluster.flush() # make sure the data directories are balanced: for node in
> cluster.nodelist(): > self.assert_balanced(node) disk_balance_test.py:48: _ _
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> disk_balance_test.py:186: in assert_balanced assert_almost_equal(*new_sums,
> error=0.1, error_message=node.name) _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ args = (2534183, 2762123, 2423706)
> kwargs = {'error': 0.1, 'error_message': 'node1'}, error = 0.1, vmax =
> 2762123 vmin = 2423706, error_message = 'node1' def
> assert_almost_equal(*args, **kwargs): """ Assert variable number of arguments
> all fall within a margin of error. @params *args variable number of numerical
> arguments to check @params error Optional margin of error. Default 0.16
> @params error_message Optional error message to print. Default '' Examples:
> assert_almost_equal(sizes[2], init_size) assert_almost_equal(ttl_session1,
> ttl_session2[0][0], error=0.005) """ error = kwargs['error'] if 'error' in
> kwargs else 0.16 vmax = max(args) vmin = min(args) error_message = '' if
> 'error_message' not in kwargs else kwargs['error_message'] assert vmin > vmax
> * (1.0 - error) or vmin == vmax, \ > "values not within {:.2f}% of the max:
> {} ({})".format(error * 100, args, error_message) E AssertionError: values
> not within 10.00% of the max: (2534183, 2762123, 2423706) (node1)
> tools/assertions.py:206: AssertionError
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
