[ 
https://issues.apache.org/jira/browse/CASSANDRA-19047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789432#comment-17789432
 ] 

Andres de la Peña commented on CASSANDRA-19047:
-----------------------------------------------

I agree that it would be ideal to get rid of the deprecation warning if the 
config is just trying to disable the old {{table_count_warn_threshold}} and/or 
replacing it with the new {{{}tables_warn_threshold{}}}.

[This 
patch|https://github.com/adelapena/cassandra/commit/f89b31c692534f69945d08eed40361564cdad4eb]
 disables the old threshold if the new guardrail is enabled.

However, I'm not sure this is the best way to proceed because it would still 
log the deprecating warning if we want to disable both checks. Perhaps we could 
instead skip the deprecation warning if the value of the old threshold is 
{{{}Integer.MAX_VALUE{}}}, which effectively works as a disabled value. 
Unfortunately this might require some relatively broad changes in the config 
loader/checker.

> Guardrail for the number of tables is not working
> -------------------------------------------------
>
>                 Key: CASSANDRA-19047
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-19047
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Cluster/Schema
>            Reporter: Mohammad Aburadeh
>            Priority: Urgent
>
> Hi, 
> We installed Cassandra 4.1.3 and we got the following warning when creating 
> more than 150 tables: 
> {code:java}
> WARN  [Native-Transport-Requests-6] 2023-11-21 18:35:24,585 
> CreateTableStatement.java:421 - Cluster already contains 161 tables in 6 
> keyspaces. Having a large number of tables will significantly slow down 
> schema dependent cluster operations. {code}
> I tried to disable "table_count_warn_threshold" by setting its value to "-1" 
> but that did not work. 
> Then I tried to set the guardrail for number of tables to "-1" to disable the 
> above but did not work as well. It seems there is no way to disable checking 
> the number of tables. 
> Also,  I tried to set "tables_warn_threshold" to a value less than 
> "tables_count_warn_threshold", it seems Cassandra always uses 
> "tables_count_warn_threshold" when throwing the warning. 
> *Two issues in Cassandra 4.1.3:* 
> 1- There should be a way to disable this feature. Either by setting the 
> guardrail parameter to -1 or setting tables_count_warn_threshold to -1. 
> 2- The guardrail for number of tables should overwrite 
> tables_count_warn_threshold because I always get the following warning when I 
> try to increase the number of tables: 
> {code:java}
> WARN  [main] 2023-11-21 18:26:16,988 YamlConfigurationLoader.java:427 - 
> [keyspace_count_warn_threshold, table_count_warn_threshold] parameters have 
> been deprecated. They have new names and/or value format; For more 
> information, please refer to NEWS.txt {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to