[
https://issues.apache.org/jira/browse/CASSANDRA-19015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790070#comment-17790070
]
Stefan Miklosovic commented on CASSANDRA-19015:
-----------------------------------------------
Hi [~zaaath] thank you for your effort so far! Great progress. I was looking
into the differences in the output and how it is now is this:
!image-2023-11-27-13-36-39-282.png!
I think that non-human output should print just raw numbers (the output on the
right). For example, if we take a look at "Max SSTable size" which is 6.371
KiB, that should be just a number, in bytes. Same for "Bytes repaired" and
"Bytes unrepaired" and "Bytes pending repair". All other figures are just plain
numbers.
On the other hand, human output (on the left), just reflects this and it should
contain appropriate size units. It should all have consistent units, if we e.g.
talk about bytes, the unit should be "B", not "bytes". Also, if you notice, for
example, "Space used (live)" is "6.37 KiB" but "Max SSTable size" is
"6.371KiB". Why is there a space? We either separate it with space everywhere
or nowhere. I prefer to put space there. It is also once with 3 decimal points
and the second time with just 2. This should be aligned as well.
I am very sorry if it seems like we are postponing the merge, it may be a
little bit frustrating, I get that.
What we could do is that we just merge the latencies and time output as is in
the current patch and we can cover the sizes in another ticket. How does that
sound to you?
> Nodetool 'tablestats' formatting uses inconsistent significant digits
> ---------------------------------------------------------------------
>
> Key: CASSANDRA-19015
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19015
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/nodetool
> Reporter: Brad Schoening
> Assignee: Leo Toff
> Priority: Low
> Fix For: 5.x
>
> Attachments: CASSANDRA-19015-1.txt, CASSANDRA-19015-2.txt,
> CASSANDRA-19015-3.txt, CASSANDRA-19015.txt, image-2023-11-27-13-36-39-282.png
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Nodetool reports milliseconds (ms) with anywhere from 3 to 15 significant
> digits. Ratios use five or sixteen decimal places. Averages use 1 or 13
> decimal places.
> * milliseconds should use 3 decimal places
> * ratios should use 3 decimal places (tenths of a percent)
> * averages should use 1 or 2
> For readability, it would be helpful if large integers had comma separators.
> I.e., space used: as 1,463,210,998,523 and/or in GiB/MiB/KiB. It's unclear
> if the exact disk size is somehow useful, as it may change minute-by-minute,
> if not, rounding would be best, or displaying both Space used (live):
> 1,463,210,998,523 (1,463GiB)
> Total number of tables: 83
> ----------------
> Keyspace : X
> Read Count: 1007337271
> Read Latency: 8.485891803649942 ms
> Write Count: 67550181
> Write Latency: 0.02556443163342523 ms
> Pending Flushes: 0
> Table: Y
> SSTable count: 7183
> Old SSTable count: 0
> SSTables in each level: [0, 9, 92, 754, 6328, 0, 0, 0, 0]
> Space used (live): 1463210998523
> Space used (total): 1463210998523
> Space used by snapshots (total): 0
> Off heap memory used (total): 607419608
> SSTable Compression Ratio: 0.3146620992793412
> Number of partitions (estimate): 24784137
> Memtable cell count: 106067
> Memtable data size: 248539982
> Memtable off heap memory used: 0
> Memtable switch count: 256
> Local read count: 865440924
> Local read latency: 6.857 ms
> Local write count: 13881409
> Local write latency: 0.037 ms
> Pending flushes: 0
> Percent repaired: 0.0
> Bytes repaired: 0.000KiB
> Bytes unrepaired: 4315.386GiB
> Bytes pending repair: 0.000KiB
> Bloom filter false positives: 11027855
> Bloom filter false ratio: 0.01099
> Bloom filter space used: 33590024
> Bloom filter off heap memory used: 33532560
> Index summary off heap memory used: 8174024
> Compression metadata off heap memory used: 565713024
> Compacted partition minimum bytes: 36
> Compacted partition maximum bytes: 17797419593
> Compacted partition mean bytes: 189740
> Average live cells per slice (last five minutes): 1443.2146104466253
> Maximum live cells per slice (last five minutes): 105778
> Average tombstones per slice (last five minutes): 1.0
> Maximum tombstones per slice (last five minutes): 1
> Dropped Mutations: 0
> Droppable tombstone ratio: 0.00000
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
